[ObjCExport] Fix property getter translation

^KT-79475 Fixed

Author: elevenetc

native/objcexport-header-generator/impl/analysis-api/src/org/jetbrains/kotlin/objcexport/getObjCPropertyGetter.kt

@@ -22,7 +22,7 @@ internal fun ObjCExportContext.getObjCPropertyGetter(symbol: KaPropertySymbol, o
 
     val symbolGetter = symbol.getter
     val getterBridge = if (symbolGetter == null) error("KtPropertySymbol.getter is undefined") else getFunctionMethodBridge(symbolGetter)
-    val getterSelector = getSelector(symbolGetter, getterBridge)
+    val getterSelector = getSelector(symbolGetter, getterBridge, true)
 
     return if (getterSelector != objCName && getterSelector.isNotBlank()) getterSelector else null
 }

native/objcexport-header-generator/impl/analysis-api/src/org/jetbrains/kotlin/objcexport/translateToObjCMethod.kt

@@ -223,7 +223,7 @@ internal fun splitSelector(selector: String): List<String> {
 /**
  * [org.jetbrains.kotlin.backend.konan.objcexport.ObjCExportNamerImpl.getSelector]
  */
-fun ObjCExportContext.getSelector(symbol: KaFunctionSymbol, methodBridge: MethodBridge): String {
+fun ObjCExportContext.getSelector(symbol: KaFunctionSymbol, methodBridge: MethodBridge, isPropertyGetter: Boolean = false): String {
 
     val parameters = valueParametersAssociated(methodBridge, symbol)
     val method = symbol
@@ -284,7 +284,7 @@ fun ObjCExportContext.getSelector(symbol: KaFunctionSymbol, methodBridge: Method
             sb.append(name)
         }
 
-        sb.append(':')
+        if (!isPropertyGetter) sb.append(':')
     }
     return sb.toString()
 }

native/objcexport-header-generator/test/org/jetbrains/kotlin/backend/konan/tests/ObjCExportHeaderGeneratorTest.kt

@@ -665,6 +665,11 @@ class ObjCExportHeaderGeneratorTest(private val generator: HeaderGenerator) {
         doTest(headersTestDataDir.resolve("anyMethodsOverride"))
     }
 
+    @Test
+    fun `test - property getter without colon`() {
+        doTest(headersTestDataDir.resolve("propertyGetter"))
+    }
+
     private fun doTest(root: File, configuration: Configuration = Configuration()) {
         if (!root.isDirectory) fail("Expected ${root.absolutePath} to be directory")
         val generatedHeaders = generator.generateHeaders(root, configuration).toString()

native/objcexport-header-generator/testData/headers/propertyGetter/!propertyGetter.h

@@ -0,0 +1,35 @@
+#import <Foundation/NSArray.h>
+#import <Foundation/NSDictionary.h>
+#import <Foundation/NSError.h>
+#import <Foundation/NSObject.h>
+#import <Foundation/NSSet.h>
+#import <Foundation/NSString.h>
+#import <Foundation/NSValue.h>
+
+@class Foo;
+
+NS_ASSUME_NONNULL_BEGIN
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunknown-warning-option"
+#pragma clang diagnostic ignored "-Wincompatible-property-type"
+#pragma clang diagnostic ignored "-Wnullability"
+
+#pragma push_macro("_Nullable_result")
+#if !__has_feature(nullability_nullable_result)
+#undef _Nullable_result
+#define _Nullable_result _Nullable
+#endif
+
+__attribute__((objc_subclassing_restricted))
+@interface Foo : Base
+- (instancetype)init __attribute__((swift_name("init()"))) __attribute__((objc_designated_initializer));
++ (instancetype)new __attribute__((availability(swift, unavailable, message="use object initializers instead")));
+@end
+
+@interface Foo (Extensions)
+@property (readonly, getter=double) double double_ __attribute__((swift_name("double_")));
+@end
+
+#pragma pop_macro("_Nullable_result")
+#pragma clang diagnostic pop
+NS_ASSUME_NONNULL_END

native/objcexport-header-generator/testData/headers/propertyGetter/Foo.kt

@@ -0,0 +1,2 @@
+class Foo
+val Foo.double: Double get() = 42.0