[FIR] Report NO_CONSTRUCTOR instead of UNRESOLVED_REFERENCE

on calls to annotations without constructors

KT-20677

Author: KvanTTT

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/calls/FirCallResolver.kt

@@ -639,17 +639,19 @@ class FirCallResolver(
 
             val callInfo = toCallInfo(annotation, reference)
 
-            val resolutionResult = constructorSymbol
-                ?.let { runResolutionForGivenSymbol(callInfo, it) }
-                ?: ResolutionResult(callInfo, CandidateApplicability.HIDDEN, emptyList())
-            createResolvedNamedReference(
-                reference,
-                reference.name,
-                callInfo,
-                resolutionResult.candidates,
-                resolutionResult.applicability,
-                explicitReceiver = null
-            )
+            if (constructorSymbol != null) {
+                val resolutionResult = runResolutionForGivenSymbol(callInfo, constructorSymbol)
+                createResolvedNamedReference(
+                    reference,
+                    reference.name,
+                    callInfo,
+                    resolutionResult.candidates,
+                    resolutionResult.applicability,
+                    explicitReceiver = null
+                )
+            } else {
+                buildReferenceWithErrorCandidate(callInfo, ConeNoConstructorError, reference.source)
+            }
         } else {
             annotation.replaceArgumentList(annotation.argumentList.transform(transformer, ResolutionMode.ContextDependent))
 

compiler/testData/diagnostics/nativeTests/multiplatform/overrideInit_expectAnnotation.fir.kt

@@ -1,5 +1,5 @@
 // LANGUAGE: +MultiPlatformProjects
-// DIAGNOSTICS: -UNUSED_PARAMETER -UNRESOLVED_REFERENCE
+// DIAGNOSTICS: -UNUSED_PARAMETER
 // WITH_STDLIB
 // WITH_PLATFORM_LIBS
 
@@ -16,13 +16,13 @@ expect annotation class MyOverrideInit
 
 class DoesNotOverride : NSAssertionHandler {
     <!CONSTRUCTOR_DOES_NOT_OVERRIDE_ANY_SUPER_CONSTRUCTOR!>@OptIn(kotlinx.cinterop.BetaInteropApi::class)
-    @MyOverrideInit
+    @<!NO_CONSTRUCTOR!>MyOverrideInit<!>
     constructor(x: Int) { }<!>
 }
 
 class OverridesOverriden : NSString {
     <!CONSTRUCTOR_OVERRIDES_ALREADY_OVERRIDDEN_OBJC_INITIALIZER!>@OptIn(kotlinx.cinterop.BetaInteropApi::class)
-    @MyOverrideInit
+    @<!NO_CONSTRUCTOR!>MyOverrideInit<!>
     constructor(coder: NSCoder) { }<!>
 
     @Suppress("OVERRIDE_DEPRECATION")

compiler/testData/diagnostics/nativeTests/multiplatform/overrideInit_expectAnnotation.kt

@@ -1,5 +1,5 @@
 // LANGUAGE: +MultiPlatformProjects
-// DIAGNOSTICS: -UNUSED_PARAMETER -UNRESOLVED_REFERENCE
+// DIAGNOSTICS: -UNUSED_PARAMETER
 // WITH_STDLIB
 // WITH_PLATFORM_LIBS
 

compiler/testData/diagnostics/nativeTests/multiplatform/overrideInit_expectAnnotation.ll.kt

@@ -2,7 +2,7 @@
 // Checkers are run with Common session in Analysis API, so they can't see actualized declarations
 // LL_FIR_DIVERGENCE
 // LANGUAGE: +MultiPlatformProjects
-// DIAGNOSTICS: -UNUSED_PARAMETER -UNRESOLVED_REFERENCE
+// DIAGNOSTICS: -UNUSED_PARAMETER
 // WITH_STDLIB
 // WITH_PLATFORM_LIBS
 
@@ -19,13 +19,13 @@ expect annotation class MyOverrideInit
 
 class DoesNotOverride : NSAssertionHandler {
     @OptIn(kotlinx.cinterop.BetaInteropApi::class)
-    @MyOverrideInit
+    @<!NO_CONSTRUCTOR!>MyOverrideInit<!>
     constructor(x: Int) { }
 }
 
 class OverridesOverriden : NSString {
     @OptIn(kotlinx.cinterop.BetaInteropApi::class)
-    @MyOverrideInit
+    @<!NO_CONSTRUCTOR!>MyOverrideInit<!>
     constructor(coder: NSCoder) { }
 
     @Suppress("OVERRIDE_DEPRECATION")

compiler/testData/diagnostics/tests/multiplatform/errorWhenUseExpectAnnWithoutDefaultConstructor.fir.kt

@@ -5,12 +5,12 @@
 
 <!NO_ACTUAL_FOR_EXPECT{JVM}!>expect<!> annotation class Ann
 
-@<!UNRESOLVED_REFERENCE!>Ann<!>
+<!NO_CONSTRUCTOR!>@Ann<!>
 fun commonFoo() {}
 
 // MODULE: m1-jvm()()(m1-common)
 
-@<!UNRESOLVED_REFERENCE!>Ann<!>
+<!NO_CONSTRUCTOR!>@Ann<!>
 fun platformFoo() {}
 
 /* GENERATED_FIR_TAGS: annotationDeclaration, expect, functionDeclaration */

compiler/testData/diagnostics/tests/multiplatform/errorWhenUseExpectAnnWithoutDefaultConstructor.ll.kt

@@ -5,12 +5,12 @@
 
 expect annotation class Ann
 
-@<!UNRESOLVED_REFERENCE!>Ann<!>
+<!NO_CONSTRUCTOR!>@Ann<!>
 fun commonFoo() {}
 
 // MODULE: m1-jvm()()(m1-common)
 
-@<!UNRESOLVED_REFERENCE!>Ann<!>
+<!NO_CONSTRUCTOR!>@Ann<!>
 fun platformFoo() {}
 
 /* GENERATED_FIR_TAGS: annotationDeclaration, expect, functionDeclaration */

compiler/testData/diagnostics/tests/multiplatform/headerClass/actualClassWithDefaultValuesInAnnotationViaTypealias.fir.kt

@@ -11,7 +11,7 @@ expect annotation class Foo5()
 expect annotation class Foo6()
 <!EXPECT_ACTUAL_IR_INCOMPATIBILITY{JVM}!>expect<!> annotation class Foo7<!EXPECT_ACTUAL_IR_MISMATCH{JVM}!>()<!>
 
-@<!UNRESOLVED_REFERENCE!>Foo1<!>
+<!NO_CONSTRUCTOR!>@Foo1<!>
 fun foo() {}
 
 @Foo5

compiler/testData/diagnostics/tests/multiplatform/headerClass/actualClassWithDefaultValuesInAnnotationViaTypealias.ll.kt

@@ -11,7 +11,7 @@ expect annotation class Foo5()
 expect annotation class Foo6()
 expect annotation class Foo7()
 
-@<!UNRESOLVED_REFERENCE!>Foo1<!>
+<!NO_CONSTRUCTOR!>@Foo1<!>
 fun foo() {}
 
 @Foo5