Skip to content

Update pi.c: improve the performance of is_prime #5515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update pi.c: improve the performance of is_prime #5515

wants to merge 1 commit into from
+3 −3

Conversation

Summer-the-coder
Copy link

Checking the remainder of division by 3 at the beginning lets us do less checks in the loop overall.

@Summer-the-coder Summer-the-coder requested review from a team as code owners October 1, 2025 13:58
@sbogolepov
Copy link
Contributor

Hey! This code is part of our benchmark suite. Even if the benchmark code can be improved, changing it would affect benchmark numbers which affects historical compatibility.

@sbogolepov sbogolepov closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-bannykh anton-bannykh Awaiting requested review from anton-bannykh anton-bannykh is a code owner automatically assigned from JetBrains/kotlin-native

@PavelPunegov PavelPunegov Awaiting requested review from PavelPunegov PavelPunegov is a code owner automatically assigned from JetBrains/kotlin-performance-qa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Summer-the-coder @sbogolepov