Skip to content

Commit b0e3a5f

Browse files
committed
Psi: rename FSharpResolvedSymbolsCache -> FcsResolvedSymbolsCache
1 parent 69c93b6 commit b0e3a5f

16 files changed

+67
-67
lines changed

ReSharper.FSharp/src/FSharp.Psi.Features/src/LanguageService/FSharpLanguageService.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ type FSharpLanguageService(languageType, constantValueService, cacheProvider: FS
3131

3232
let getSymbolsCache (psiModule: IPsiModule) =
3333
if isNull psiModule then null else
34-
psiModule.GetSolution().GetComponent<IFSharpResolvedSymbolsCache>()
34+
psiModule.GetSolution().GetComponent<IFcsResolvedSymbolsCache>()
3535

3636
override x.IsCaseSensitive = true
3737
override x.SupportTypeMemberCache = true

ReSharper.FSharp/src/FSharp.Psi.Features/src/Parsing/FSharpParser.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ open JetBrains.ReSharper.Psi
1515
open JetBrains.ReSharper.Psi.Parsing
1616

1717
type FSharpParser(lexer: ILexer, document: IDocument, path: FileSystemPath, sourceFile: IPsiSourceFile,
18-
checkerService: FcsCheckerService, symbolsCache: IFSharpResolvedSymbolsCache) =
18+
checkerService: FcsCheckerService, symbolsCache: IFcsResolvedSymbolsCache) =
1919

2020
let tryCreateTreeBuilder lexer lifetime =
2121
Option.map (fun (parseResults: FSharpParseFileResults) ->

ReSharper.FSharp/src/FSharp.Psi/src/Features/Daemon/Stages/HighlightIdentifiersStage.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public class HighlightIdentifiersStageProcess : FSharpDaemonStageProcessBase
3434
public HighlightIdentifiersStageProcess([NotNull] IFSharpFile fsFile, [NotNull] IDaemonProcess process)
3535
: base(fsFile, process) => myDocument = process.Document;
3636

37-
private void AddHighlightings(IEnumerable<FSharpResolvedSymbolUse> symbolsUses,
37+
private void AddHighlightings(IEnumerable<FcsResolvedSymbolUse> symbolsUses,
3838
ICollection<HighlightingInfo> highlightings)
3939
{
4040
foreach (var resolvedSymbolUse in symbolsUses)

ReSharper.FSharp/src/FSharp.Psi/src/Impl/Tree/FSharpFileBase.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ internal abstract class FSharpFileBase : FileElementBase, IFSharpFileCheckInfoOw
2121
public FcsCheckerService CheckerService => FcsCheckerService;
2222

2323
// ReSharper disable once NotNullMemberIsNotInitialized
24-
public IFSharpResolvedSymbolsCache ResolvedSymbolsCache { get; set; }
24+
public IFcsResolvedSymbolsCache ResolvedSymbolsCache { get; set; }
2525

2626
private readonly CachedPsiValue<FSharpOption<FSharpParseFileResults>> myParseResults =
2727
new FileCachedPsiValue<FSharpOption<FSharpParseFileResults>>();
@@ -47,10 +47,10 @@ public FSharpOption<FSharpParseAndCheckResults> GetParseAndCheckResults(bool all
4747
public FSharpSymbol GetSymbol(int offset) =>
4848
ResolvedSymbolsCache.GetSymbol(SourceFile, offset);
4949

50-
public IReadOnlyList<FSharpResolvedSymbolUse> GetAllResolvedSymbols(FSharpCheckFileResults checkResults = null) =>
50+
public IReadOnlyList<FcsResolvedSymbolUse> GetAllResolvedSymbols(FSharpCheckFileResults checkResults = null) =>
5151
ResolvedSymbolsCache.GetAllResolvedSymbols(SourceFile);
5252

53-
public IReadOnlyList<FSharpResolvedSymbolUse> GetAllDeclaredSymbols(FSharpCheckFileResults checkResults = null) =>
53+
public IReadOnlyList<FcsResolvedSymbolUse> GetAllDeclaredSymbols(FSharpCheckFileResults checkResults = null) =>
5454
ResolvedSymbolsCache.GetAllDeclaredSymbols(SourceFile);
5555

5656
public FSharpSymbolUse GetSymbolUse(int offset) =>
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
using System.Collections.Generic;
2+
using FSharp.Compiler.CodeAnalysis;
3+
using FSharp.Compiler.Symbols;
4+
using JetBrains.Util;
5+
6+
namespace JetBrains.ReSharper.Plugins.FSharp.Psi.Resolve
7+
{
8+
public class EmptyFcsFileResolvedSymbols : IFcsFileResolvedSymbols
9+
{
10+
public static IFcsFileResolvedSymbols Instance = new EmptyFcsFileResolvedSymbols();
11+
12+
public FSharpSymbolUse GetSymbolUse(int offset) => null;
13+
public FSharpSymbolUse GetSymbolDeclaration(int offset) => null;
14+
15+
public IReadOnlyList<FcsResolvedSymbolUse> GetAllDeclaredSymbols() =>
16+
EmptyList<FcsResolvedSymbolUse>.Instance;
17+
18+
public IReadOnlyList<FcsResolvedSymbolUse> GetAllResolvedSymbols() =>
19+
EmptyList<FcsResolvedSymbolUse>.Instance;
20+
21+
public FSharpSymbol GetSymbol(int offset) => null;
22+
}
23+
}

ReSharper.FSharp/src/FSharp.Psi/src/Resolve/EmptyFileResolvedSymbols.cs

Lines changed: 0 additions & 23 deletions
This file was deleted.

ReSharper.FSharp/src/FSharp.Psi/src/Resolve/FSharpMiscModuleResolvedSymbols.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public void Invalidate(IPsiSourceFile sourceFile)
1414
{
1515
}
1616

17-
public IFSharpFileResolvedSymbols GetResolvedSymbols(IPsiSourceFile sourceFile) =>
18-
EmptyFileResolvedSymbols.Instance;
17+
public IFcsFileResolvedSymbols GetResolvedSymbols(IPsiSourceFile sourceFile) =>
18+
EmptyFcsFileResolvedSymbols.Instance;
1919
}
2020
}

ReSharper.FSharp/src/FSharp.Psi/src/Resolve/FSharpModuleResolvedSymbols.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace JetBrains.ReSharper.Plugins.FSharp.Psi.Resolve
77
{
88
public class FSharpModuleResolvedSymbols : IFSharpModuleResolvedSymbols
99
{
10-
private readonly FSharpFileResolvedSymbols[] myFileResolvedSymbols;
10+
private readonly FcsFileResolvedSymbols[] myFileResolvedSymbols;
1111

1212
public IPsiModule PsiModule { get; }
1313
public FcsCheckerService CheckerService { get; }
@@ -18,7 +18,7 @@ public class FSharpModuleResolvedSymbols : IFSharpModuleResolvedSymbols
1818
public FSharpModuleResolvedSymbols(IPsiModule psiModule, int filesCount, FcsCheckerService checkerService,
1919
IFcsProjectProvider fcsProjectProvider)
2020
{
21-
myFileResolvedSymbols = new FSharpFileResolvedSymbols[filesCount];
21+
myFileResolvedSymbols = new FcsFileResolvedSymbols[filesCount];
2222

2323
PsiModule = psiModule;
2424
CheckerService = checkerService;
@@ -39,13 +39,13 @@ public void Invalidate(IPsiSourceFile sourceFile)
3939
}
4040
}
4141

42-
private FSharpFileResolvedSymbols TryGetResolvedSymbols(int fileIndex)
42+
private FcsFileResolvedSymbols TryGetResolvedSymbols(int fileIndex)
4343
{
4444
using (myLock.UsingReadLock())
4545
return myFileResolvedSymbols[fileIndex];
4646
}
4747

48-
public IFSharpFileResolvedSymbols GetResolvedSymbols(IPsiSourceFile sourceFile)
48+
public IFcsFileResolvedSymbols GetResolvedSymbols(IPsiSourceFile sourceFile)
4949
{
5050
var fileIndex = FcsProjectProvider.GetFileIndex(sourceFile);
5151
var fileResolvedSymbols = TryGetResolvedSymbols(fileIndex);
@@ -58,7 +58,7 @@ public IFSharpFileResolvedSymbols GetResolvedSymbols(IPsiSourceFile sourceFile)
5858
if (fileResolvedSymbols != null)
5959
return fileResolvedSymbols;
6060

61-
fileResolvedSymbols = new FSharpFileResolvedSymbols(sourceFile, CheckerService);
61+
fileResolvedSymbols = new FcsFileResolvedSymbols(sourceFile, CheckerService);
6262
myFileResolvedSymbols[fileIndex] = fileResolvedSymbols;
6363
}
6464

ReSharper.FSharp/src/FSharp.Psi/src/Resolve/FSharpFileResolvedSymbols.cs renamed to ReSharper.FSharp/src/FSharp.Psi/src/Resolve/FcsFileResolvedSymbols.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
namespace JetBrains.ReSharper.Plugins.FSharp.Psi.Resolve
2525
{
26-
public class FSharpFileResolvedSymbols : IFSharpFileResolvedSymbols
26+
public class FcsFileResolvedSymbols : IFcsFileResolvedSymbols
2727
{
2828
private const string OpName = "FSharpFileResolvedSymbols";
2929

@@ -33,7 +33,7 @@ public class FSharpFileResolvedSymbols : IFSharpFileResolvedSymbols
3333
[NotNull] public IPsiSourceFile SourceFile { get; }
3434
[NotNull] public FcsCheckerService CheckerService { get; }
3535

36-
public FSharpFileResolvedSymbols([NotNull] IPsiSourceFile sourceFile, [NotNull] FcsCheckerService checkerService)
36+
public FcsFileResolvedSymbols([NotNull] IPsiSourceFile sourceFile, [NotNull] FcsCheckerService checkerService)
3737
{
3838
SourceFile = sourceFile;
3939
CheckerService = checkerService;
@@ -70,13 +70,13 @@ public FSharpSymbolUse GetSymbolDeclaration(int offset)
7070
return resolvedSymbols.Declarations.TryGetValue(offset)?.SymbolUse;
7171
}
7272

73-
public IReadOnlyList<FSharpResolvedSymbolUse> GetAllDeclaredSymbols()
73+
public IReadOnlyList<FcsResolvedSymbolUse> GetAllDeclaredSymbols()
7474
{
7575
var resolvedSymbols = GetResolvedSymbols();
7676
return resolvedSymbols.Declarations.Values.AsChunkIReadOnlyList();
7777
}
7878

79-
public IReadOnlyList<FSharpResolvedSymbolUse> GetAllResolvedSymbols()
79+
public IReadOnlyList<FcsResolvedSymbolUse> GetAllResolvedSymbols()
8080
{
8181
var resolvedSymbols = GetResolvedSymbols();
8282
return resolvedSymbols.Uses.Values.AsChunkIReadOnlyList();
@@ -168,12 +168,12 @@ private ResolvedSymbols CreateFileResolvedSymbols()
168168
var (caseStart, caseEnd) = caseDeclaration.GetTreeTextRange();
169169
var caseStartOffset = caseStart.Offset;
170170
var caseTextRange = new TextRange(caseStartOffset, caseEnd.Offset);
171-
resolvedSymbols.Declarations[caseStartOffset] = new FSharpResolvedSymbolUse(symbolUse, caseTextRange);
171+
resolvedSymbols.Declarations[caseStartOffset] = new FcsResolvedSymbolUse(symbolUse, caseTextRange);
172172
continue;
173173
}
174174

175175
var caseUseInBindingRange = new TextRange(startOffset, endOffset);
176-
resolvedSymbols.Uses[startOffset] = new FSharpResolvedSymbolUse(symbolUse, caseUseInBindingRange);
176+
resolvedSymbols.Uses[startOffset] = new FcsResolvedSymbolUse(symbolUse, caseUseInBindingRange);
177177
continue;
178178
}
179179
else
@@ -188,7 +188,7 @@ private ResolvedSymbols CreateFileResolvedSymbols()
188188
: FixRange(startOffset, endOffset, null, buffer, lexer);
189189
startOffset = textRange.StartOffset;
190190

191-
resolvedSymbols.Declarations[startOffset] = new FSharpResolvedSymbolUse(symbolUse, textRange);
191+
resolvedSymbols.Declarations[startOffset] = new FcsResolvedSymbolUse(symbolUse, textRange);
192192
resolvedSymbols.Uses.Remove(startOffset);
193193
}
194194
else
@@ -243,7 +243,7 @@ private ResolvedSymbols CreateFileResolvedSymbols()
243243
existingSymbol.SymbolUse.Symbol is FSharpEntity && !isCtor)
244244
continue;
245245

246-
resolvedSymbols.Uses[startOffset] = new FSharpResolvedSymbolUse(symbolUse, nameRange);
246+
resolvedSymbols.Uses[startOffset] = new FcsResolvedSymbolUse(symbolUse, nameRange);
247247
}
248248

249249
if (symbolUse.IsFromPattern)
@@ -302,13 +302,13 @@ private class ResolvedSymbols
302302
{
303303
public static readonly ResolvedSymbols Empty = new ResolvedSymbols();
304304

305-
[NotNull] internal readonly CompactMap<int, FSharpResolvedSymbolUse> Declarations;
306-
[NotNull] internal readonly CompactMap<int, FSharpResolvedSymbolUse> Uses;
305+
[NotNull] internal readonly CompactMap<int, FcsResolvedSymbolUse> Declarations;
306+
[NotNull] internal readonly CompactMap<int, FcsResolvedSymbolUse> Uses;
307307

308308
public ResolvedSymbols(int symbolUsesCount = 0)
309309
{
310-
Declarations = new CompactMap<int, FSharpResolvedSymbolUse>(symbolUsesCount / 4);
311-
Uses = new CompactMap<int, FSharpResolvedSymbolUse>(symbolUsesCount);
310+
Declarations = new CompactMap<int, FcsResolvedSymbolUse>(symbolUsesCount / 4);
311+
Uses = new CompactMap<int, FcsResolvedSymbolUse>(symbolUsesCount);
312312
}
313313
}
314314

ReSharper.FSharp/src/FSharp.Psi/src/Resolve/FSharpResolvedSymbolUse.cs renamed to ReSharper.FSharp/src/FSharp.Psi/src/Resolve/FcsResolvedSymbolUse.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44

55
namespace JetBrains.ReSharper.Plugins.FSharp.Psi.Resolve
66
{
7-
public class FSharpResolvedSymbolUse
7+
public class FcsResolvedSymbolUse
88
{
99
[NotNull]
1010
public FSharpSymbolUse SymbolUse { get; }
1111

1212
public TextRange Range { get; }
1313

14-
public FSharpResolvedSymbolUse([NotNull] FSharpSymbolUse symbolUse, TextRange range)
14+
public FcsResolvedSymbolUse([NotNull] FSharpSymbolUse symbolUse, TextRange range)
1515
{
1616
SymbolUse = symbolUse;
1717
Range = range;

0 commit comments

Comments
 (0)