Skip to content

Commit 46ac3c0

Browse files
committed
changed regression/log to use logger.SetEcho()
this seems clearer and less prone to error than WriteRecent()
1 parent 921bc26 commit 46ac3c0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

regression/log.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,11 @@ func (reg *LogRegression) regress(newRegression bool, output io.Writer, msg stri
126126
// make sure logger is clear
127127
logger.Clear()
128128

129+
// echoing log output to buffer
130+
logOutput := &strings.Builder{}
131+
logger.SetEcho(logOutput, false)
132+
133+
// start output with message
129134
output.Write([]byte(msg))
130135

131136
// create headless television. we'll use this to initialise the digester
@@ -161,9 +166,6 @@ func (reg *LogRegression) regress(newRegression bool, output io.Writer, msg stri
161166
dur, _ := time.ParseDuration("1s")
162167
tck := time.NewTicker(dur)
163168

164-
// writing log output to buffer
165-
logOutput := &strings.Builder{}
166-
167169
// run emulation
168170
err = vcs.RunForFrameCount(reg.NumFrames, func() (govern.State, error) {
169171
// if the CPU is in the KIL state then the test will never end normally
@@ -179,8 +181,6 @@ func (reg *LogRegression) regress(newRegression bool, output io.Writer, msg stri
179181
default:
180182
}
181183

182-
logger.WriteRecent(logOutput)
183-
184184
return govern.Running, nil
185185
})
186186

0 commit comments

Comments
 (0)