fixed imgui related crashes caused by parent window being too small

the crashes are caused by BeginTable() failing and then EndTable() being
called. Or BeginChild() failing and EndChild not being called.

Author: JetSetIlly

gui/sdlimgui/win_6507_pinout.go

@@ -243,8 +243,8 @@ func (win *win6507Pinout) draw() {
 			win.bodyOutline, 0, imgui.DrawCornerFlagsAll, lineThick)
 
 		imgui.PopFont()
-		imgui.EndChild()
 	}
+	imgui.EndChild()
 
 	// bus information
 	win.busInfoHeight = imguiMeasureHeight(func() {

gui/sdlimgui/win_cart_cdf_streams.go

@@ -393,9 +393,8 @@ func (win *winCDFStreams) draw(regs cdf.Registers, static mapper.CartStatic) {
 			imgui.EndGroup()
 			imgui.SameLine()
 		}
-
-		imgui.EndChild()
 	}
+	imgui.EndChild()
 
 	win.optionsHeight = imguiMeasureHeight(func() {
 		imgui.Spacing()

gui/sdlimgui/win_coproc_disasm.go

@@ -120,8 +120,8 @@ func (win *winCoProcDisasm) draw() {
 				imgui.Text("Coprocessor disassembly is disabled")
 			}
 
-			imgui.EndChild()
 		}
+		imgui.EndChild()
 
 		// draw options and status line. start height measurement
 		win.optionsHeight = imguiMeasureHeight(func() {

gui/sdlimgui/win_coproc_functions.go

@@ -92,7 +92,9 @@ func (win *winCoProcFunctions) draw() {
 		flgs |= imgui.TableFlagsSizingStretchProp
 		flgs |= imgui.TableFlagsResizable
 		flgs |= imgui.TableFlagsHideable
-		imgui.BeginTableV("##coprocFunctionsTable", numColumns, flgs, imgui.Vec2{}, 0.0)
+		if !imgui.BeginTableV("##coprocFunctionsTable", numColumns, flgs, imgui.Vec2{}, 0.0) {
+			return
+		}
 
 		width := imgui.ContentRegionAvail().X
 		imgui.TableSetupColumnV("Name", imgui.TableColumnFlagsPreferSortDescending|imgui.TableColumnFlagsNoHide, width*0.5, 0)

gui/sdlimgui/win_coproc_globals.go

@@ -188,7 +188,9 @@ func (win *winCoProcGlobals) draw() {
 		flgs |= imgui.TableFlagsSortable
 		flgs |= imgui.TableFlagsResizable
 
-		imgui.BeginTableV("##globalsTable", numColumns, flgs, imgui.Vec2{Y: imguiRemainingWinHeight() - win.optionsHeight}, 0.0)
+		if imgui.BeginTableV("##globalsTable", numColumns, flgs, imgui.Vec2{Y: imguiRemainingWinHeight() - win.optionsHeight}, 0.0) {
+			return
+		}
 
 		// setup columns. the labelling column 2 depends on whether the coprocessor
 		// development instance has source available to it

gui/sdlimgui/win_coproc_locals.go

@@ -108,7 +108,9 @@ func (win *winCoProcLocals) draw() {
 		flgs |= imgui.TableFlagsResizable
 		flgs |= imgui.TableFlagsHideable
 
-		imgui.BeginTableV("##localsTable", numColumns, flgs, imgui.Vec2{Y: imguiRemainingWinHeight() - win.optionsHeight}, 0.0)
+		if !imgui.BeginTableV("##localsTable", numColumns, flgs, imgui.Vec2{Y: imguiRemainingWinHeight() - win.optionsHeight}, 0.0) {
+			return
+		}
 
 		// setup columns. the labelling column 2 depends on whether the coprocessor
 		// development instance has source available to it

gui/sdlimgui/win_disasm.go

@@ -311,12 +311,12 @@ func (win *winDisasm) drawOptions(currBank mapper.BankInfo) {
 	})
 }
 
-func (win *winDisasm) startTable() {
+func (win *winDisasm) startTable() bool {
 	numColumns := 6
 	flgs := imgui.TableFlagsNone
 	flgs |= imgui.TableFlagsSizingFixedFit
 	if !imgui.BeginTableV("bank", numColumns, flgs, imgui.Vec2{}, 0) {
-		return
+		return false
 	}
 
 	operandWidth := imgui.ContentRegionAvail().X - imgui.CurrentStyle().ItemSpacing().X*float32(numColumns)
@@ -328,6 +328,8 @@ func (win *winDisasm) startTable() {
 	imgui.TableSetupColumnV("##operand", imgui.TableColumnFlagsNone, operandWidth, 3)
 	imgui.TableSetupColumnV("##cycles", imgui.TableColumnFlagsNone, win.widthCycles, 4)
 	imgui.TableSetupColumnV("##notes", imgui.TableColumnFlagsNone, win.widthNotes, 5)
+
+	return true
 }
 
 // drawBank specified by bank argument.
@@ -386,14 +388,17 @@ func (win *winDisasm) drawBank(currBank mapper.BankInfo, focusAddr uint16) {
 		}
 
 		// iterateDraw presents the entry according to the current rules
-		iterateDraw := func(e *disassembly.Entry) {
+		iterateDraw := func(e *disassembly.Entry) bool {
 			if headerRequired {
 				imgui.EndTable()
 				imgui.Text(fmt.Sprintf("Bank %d", iterateBank))
-				win.startTable()
+				if !win.startTable() {
+					return false
+				}
 				headerRequired = false
 			}
 			win.drawEntry(currBank, e, focusAddr, onBank, iterateBank)
+			return true
 		}
 
 		// alter iterate functions according to selected filter
@@ -413,15 +418,18 @@ func (win *winDisasm) drawBank(currBank mapper.BankInfo, focusAddr uint16) {
 				iterateIdx++
 				return iterateIdx < len(dsmEntries.Entries[iterateBank])
 			}
-			iterateDraw = func(e *disassembly.Entry) {
+			iterateDraw = func(e *disassembly.Entry) bool {
 				if e == nil {
-					return
+					return true
 				}
 				win.drawLabel(e, iterateBank)
 				win.drawEntry(currBank, e, focusAddr, onBank, iterateBank)
 				if currBank.ExecutingCoprocessor && onBank && e.Result.Address&memorymap.CartridgeBits == focusAddr {
-					win.drawEntryCoProcessorExecution()
+					if !win.drawEntryCoProcessorExecution() {
+						return false
+					}
 				}
+				return true
 			}
 		case filterCPUBug:
 			iterateFilter = func(e *disassembly.Entry) bool {
@@ -476,7 +484,9 @@ func (win *winDisasm) drawBank(currBank mapper.BankInfo, focusAddr uint16) {
 			return
 		}
 
-		win.startTable()
+		if !win.startTable() {
+			return
+		}
 
 		// wrap list clipper in anonymous function call. convenient to just
 		// return from the function from inside a nested loop
@@ -571,42 +581,41 @@ func (win *winDisasm) drawBank(currBank mapper.BankInfo, focusAddr uint16) {
 	imgui.EndChild()
 }
 
-func (win *winDisasm) drawLabel(e *disassembly.Entry, bank int) {
+func (win *winDisasm) drawLabel(e *disassembly.Entry, bank int) bool {
 	if len(e.Label.Resolve()) == 0 {
-		return
+		return true
 	}
 
 	// end existing disasm table before drawing label. (re)start table before
 	// the end of the function
 	imgui.EndTable()
-	defer win.startTable()
 
 	imgui.PushStyleColor(imgui.StyleColorHeaderHovered, win.img.cols.DisasmHover)
 	imgui.PushStyleColor(imgui.StyleColorHeaderActive, win.img.cols.DisasmHover)
-	defer imgui.PopStyleColorV(2)
 	imgui.SelectableV("", false, imgui.SelectableFlagsNone, imgui.Vec2{0, 0})
 	imgui.SameLine()
-
 	imgui.Text(e.Label.Resolve())
+	imgui.PopStyleColorV(2)
+
+	return win.startTable()
 }
 
 func (win *winDisasm) drawCoProcTooltip() {
 	win.img.imguiTooltipSimple("Coprocessor is executing")
 }
 
-func (win *winDisasm) drawEntryCoProcessorExecution() {
+func (win *winDisasm) drawEntryCoProcessorExecution() bool {
 	imgui.EndTable()
-	defer win.startTable()
 
 	imgui.PushStyleColor(imgui.StyleColorHeaderHovered, win.img.cols.DisasmHover)
 	imgui.PushStyleColor(imgui.StyleColorHeaderActive, win.img.cols.DisasmHover)
-	defer imgui.PopStyleColorV(2)
 	imgui.SelectableV("", false, imgui.SelectableFlagsNone, imgui.Vec2{0, 0})
-
 	win.drawCoProcTooltip()
-
 	imgui.SameLine()
 	imgui.Text(fmt.Sprintf("    %c 6507 will resume here", fonts.CoProcExecution))
+	imgui.PopStyleColorV(2)
+
+	return win.startTable()
 }
 
 func (win *winDisasm) drawEntry(currBank mapper.BankInfo, e *disassembly.Entry, focusAddr uint16, onBank bool, bank int) {

gui/sdlimgui/win_terminal.go

@@ -135,8 +135,8 @@ func (win *winTerm) debuggerDraw() bool {
 			imgui.SetScrollHereY(0.0)
 		}
 
-		imgui.EndChild()
 	}
+	imgui.EndChild()
 
 	// context menu for scrollback area
 	if imgui.BeginPopupContextItem() {