corrected parameters used for NewStick()

corrected initial value of swcha_p in riot. this fixes the problem of
some single button joystick using ROMs from not responding to button
presses. this seems odd because swcha has nothing to do with the fire
button. without investigating I can only guess that the code is
branching on what looks like an impossible joystick position and thereby
preventing checking the fire button

Author: JetSetIlly

hardware/console.go

@@ -140,7 +140,7 @@ func (con *Console) Insert(c external.CartridgeInsertor) error {
 		}
 		if _, ok := con.players[1].(*peripherals.Stick); !ok {
 			con.players[1].Unplug()
-			con.players[1] = peripherals.NewStick(con.RIOT, con.TIA, false, true)
+			con.players[1] = peripherals.NewStick(con.RIOT, con.TIA, true, true)
 			con.players[1].Reset()
 		}
 	case "paddle":
@@ -173,7 +173,7 @@ func (con *Console) Insert(c external.CartridgeInsertor) error {
 		}
 		if _, ok := con.players[1].(*peripherals.Stick); !ok {
 			con.players[1].Unplug()
-			con.players[1] = peripherals.NewStick(con.RIOT, con.TIA, false, true)
+			con.players[1] = peripherals.NewStick(con.RIOT, con.TIA, true, false)
 			con.players[1].Reset()
 		}
 	case "snes2atari":
@@ -184,7 +184,7 @@ func (con *Console) Insert(c external.CartridgeInsertor) error {
 		}
 		if _, ok := con.players[1].(*peripherals.Stick); !ok {
 			con.players[1].Unplug()
-			con.players[1] = peripherals.NewStick(con.RIOT, con.TIA, false, true)
+			con.players[1] = peripherals.NewStick(con.RIOT, con.TIA, true, true)
 			con.players[1].Reset()
 		}
 	}

hardware/riot/riot.go

@@ -78,13 +78,13 @@ func (riot *RIOT) Reset() {
 	riot.swcha_w = 0x00
 	riot.swcha_mux = 0xff
 	riot.swacnt = 0x00
-	riot.swcha_p = 0x00
+	riot.swcha_p = 0xff
 
 	// amateur pro switch selected by default (pro would be 0xff)
 	riot.swchb_w = 0x00
 	riot.swchb_mux = 0x3f
 	riot.swbcnt = 0x00
-	riot.swchb_p = 0x00
+	riot.swchb_p = 0xff
 
 	riot.timint = timintPA7
 	riot.lastReadReg = 0