Skip to content

Commit 1d6f869

Browse files
committed
onedrive: fix require sign in for Onedrive Personal
require_sign_in and regain_inherited_permissions in Onedrive Personal have been brought into line with Onedrive Business.
1 parent 8a31921 commit 1d6f869

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

backend/onedrive/metadata.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -596,12 +596,10 @@ func (m *Metadata) addPermission(ctx context.Context, p *api.PermissionsType) (n
596596

597597
req := &api.AddPermissionsRequest{
598598
Recipients: fillRecipients(p, m.fs.driveType),
599-
RequireSignIn: m.fs.driveType != driveTypePersonal, // personal and business have conflicting requirements
599+
RequireSignIn: true,
600600
Roles: p.Roles,
601601
}
602-
if m.fs.driveType != driveTypePersonal {
603-
req.RetainInheritedPermissions = false // not supported for personal
604-
}
602+
req.RetainInheritedPermissions = false
605603

606604
if p.Link != nil && p.Link.Scope == api.AnonymousScope {
607605
link, err := m.fs.PublicLink(ctx, m.remote, fs.DurationOff, false)

0 commit comments

Comments
 (0)