Merge pull request #66 from buffcode/patch-1

bracki · web-flow · commit f15cade2cdbe · 2018-03-19T22:24:39.000+01:00
Fix wrong output for invalid labels
diff --git a/src/Prometheus/Collector.php b/src/Prometheus/Collector.php
@@ -32,7 +32,7 @@ public function __construct(Adapter $storageAdapter, $namespace, $name, $help, $
         $this->help = $help;
         foreach ($labels as $label) {
             if (!preg_match(self::RE_METRIC_LABEL_NAME, $label)) {
-                throw new \InvalidArgumentException("Invalid label name: '" . $metricName . "'");
+                throw new \InvalidArgumentException("Invalid label name: '" . $label . "'");
             }
         }
         $this->labels = $labels;

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function __construct(Adapter $storageAdapter, $namespace, $name, $help, $`
`32`	`32`	`$this->help = $help;`
`33`	`33`	`foreach ($labels as $label) {`
`34`	`34`	`if (!preg_match(self::RE_METRIC_LABEL_NAME, $label)) {`
`35`		`- throw new \InvalidArgumentException("Invalid label name: '" . $metricName . "'");`
	`35`	`+ throw new \InvalidArgumentException("Invalid label name: '" . $label . "'");`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`$this->labels = $labels;`