Skip to content

Commit 29febc4

Browse files
committed
Get tests to pass (reduce travis test surface); some cleanup.
1 parent 308984d commit 29febc4

File tree

10 files changed

+23
-114
lines changed

10 files changed

+23
-114
lines changed

.ruby-gemset

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
rails-recurring-select

.travis.yml

Lines changed: 4 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -2,62 +2,9 @@ language: ruby
22
script: bundle exec rspec spec
33

44
rvm:
5-
- 2.0.0
6-
- 2.1.5
7-
- 2.2.0
8-
- 2.3.7
9-
- 2.4.9
10-
- 2.5.3
11-
- 2.6.5
12-
- jruby-19mode
5+
- 2.5.3
6+
- 2.6.5
137

148
gemfile:
15-
- spec/gemfiles/Gemfile.rails-4.0.x
16-
- spec/gemfiles/Gemfile.rails-4.1.x
17-
- spec/gemfiles/Gemfile.rails-4.2.x
18-
- spec/gemfiles/Gemfile.rails-5.0.x
19-
- spec/gemfiles/Gemfile.rails-6.0.x
20-
21-
jobs:
22-
exclude:
23-
- rvm: 2.0.0
24-
gemfile: spec/gemfiles/Gemfile.rails-5.0.x
25-
- rvm: 2.0.0
26-
gemfile: spec/gemfiles/Gemfile.rails-6.0.x
27-
- rvm: 2.1.5
28-
gemfile: spec/gemfiles/Gemfile.rails-5.0.x
29-
- rvm: 2.1.5
30-
gemfile: spec/gemfiles/Gemfile.rails-6.0.x
31-
- rvm: 2.2.0
32-
gemfile: spec/gemfiles/Gemfile.rails-5.0.x
33-
- rvm: 2.2.0
34-
gemfile: spec/gemfiles/Gemfile.rails-6.0.x
35-
- rvm: 2.3.7
36-
gemfile: spec/gemfiles/Gemfile.rails-6.0.x
37-
- rvm: 2.4.9
38-
gemfile: spec/gemfiles/Gemfile.rails-4.0.x
39-
- rvm: 2.4.9
40-
gemfile: spec/gemfiles/Gemfile.rails-4.1.x
41-
- rvm: 2.4.9
42-
gemfile: spec/gemfiles/Gemfile.rails-6.0.x
43-
- rvm: 2.5.3
44-
gemfile: spec/gemfiles/Gemfile.rails-4.0.x
45-
- rvm: 2.5.3
46-
gemfile: spec/gemfiles/Gemfile.rails-4.1.x
47-
- rvm: 2.6.5
48-
gemfile: spec/gemfiles/Gemfile.rails-4.0.x
49-
- rvm: 2.6.5
50-
gemfile: spec/gemfiles/Gemfile.rails-4.1.x
51-
- rvm: jruby-19mode
52-
gemfile: spec/gemfiles/Gemfile.rails-4.0.x
53-
- rvm: jruby-19mode
54-
gemfile: spec/gemfiles/Gemfile.rails-4.1.x
55-
- rvm: jruby-19mode
56-
gemfile: spec/gemfiles/Gemfile.rails-4.2.x
57-
58-
before_install:
59-
- gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
60-
- gem install bundler -v '< 2'
61-
62-
notifications:
63-
email: false
9+
- spec/gemfiles/Gemfile.rails-5.2.x
10+
- spec/gemfiles/Gemfile.rails-6.0.x

Gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,9 @@
11
source 'https://rubygems.org'
22
gemspec
3+
4+
gem "pg"
5+
6+
gem "jquery-rails"
7+
8+
gem "rails", "~> 5.2"
9+
gem "sass-rails", "~> 5.0"

Guardfile

Lines changed: 0 additions & 31 deletions
This file was deleted.

README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Recurring Select
22

3-
[![Build Status](https://travis-ci.org/GetJobber/recurring_select.svg?branch=master)](https://travis-ci.org/GetJobber/recurring_select) [![Code Climate](https://codeclimate.com/github/GetJobber/recurring_select.png)](https://codeclimate.com/github/GetJobber/recurring_select)
3+
[![Build Status](https://travis-ci.org/gregschmit/recurring_select.svg?branch=master)](https://travis-ci.org/GetJobber/recurring_select) [![Code Climate](https://codeclimate.com/github/gregschmit/recurring_select.png)](https://codeclimate.com/github/gregschmit/recurring_select)
44

55
This gem adds selectors and helpers for working with recurring schedules in a Rails app. It uses [ice_cube](https://github.com/seejohnrun/ice_cube) recurring scheduling gem.
66

77
Created by the [Jobber](http://getjobber.com) team for Jobber, the leading business management tool for field service companies.
88

9-
Check out the [live demo](http://recurring-select-demo.herokuapp.com/) (code in [spec/dummy](https://github.com/GetJobber/recurring_select/tree/master/spec/dummy) folder)
9+
Check out the [live demo](http://recurring-select-demo.herokuapp.com/) (code in [spec/dummy](https://github.com/GetJobber/recurring_select/tree/master/spec/dummy) folder).
1010

1111

1212
## Usage
@@ -148,9 +148,6 @@ Start the dummy server for clicking around the interface:
148148
rails s
149149
```
150150

151-
Use [Guard](https://github.com/guard/guard) and RSpec for all tests. I'd
152-
love to get Jasmine running also, but haven't had time yet.
153-
154151
Tests can be ran against different versions of Rails like so:
155152

156153
```
@@ -162,4 +159,4 @@ Feel free to open issues or send pull requests.
162159

163160
## Licensing
164161

165-
This project rocks and uses MIT-LICENSE.
162+
This project rocks and uses the MIT license.

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Bundler::GemHelper.install_tasks
1212
require 'rdoc/task'
1313
RDoc::Task.new(:rdoc) do |rdoc|
1414
rdoc.rdoc_dir = 'rdoc'
15-
rdoc.title = 'RecurringSelect'
15+
rdoc.title = 'RecurringSelect'
1616
rdoc.options << '--line-numbers'
1717
rdoc.rdoc_files.include('README.rdoc')
1818
rdoc.rdoc_files.include('lib/**/*.rb')

recurring-select.sublime-project

Lines changed: 0 additions & 8 deletions
This file was deleted.

recurring_select.gemspec

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
1-
$:.push File.expand_path("../lib", __FILE__)
2-
31
# Maintain your gem's version:
4-
require "recurring_select/version"
2+
require_relative "lib/recurring_select/version"
53

64
# Describe your gem and declare its dependencies:
75
Gem::Specification.new do |s|
8-
s.name = "recurring_select"
9-
s.version = RecurringSelect::VERSION
10-
s.authors = ["Jobber", "Forrest Zeisler", "Nathan Youngman"]
11-
s.email = ["forrest@getjobber.com"]
12-
s.homepage = "http://github.com/getjobber/recurring_select"
13-
s.summary = "A select helper which gives you magical powers to generate ice_cube rules."
6+
s.name = "recurring_select"
7+
s.version = RecurringSelect::VERSION
8+
s.authors = ["Jobber", "Forrest Zeisler", "Nathan Youngman", "Gregory Schmit"]
9+
s.email = ["schmitgreg@gmail.com"]
10+
s.homepage = "http://github.com/getjobber/recurring_select"
11+
s.summary = "A select helper which gives you magical powers to generate ice_cube rules."
1412
s.description = "This gem provides a useful interface for creating recurring rules for the ice_cube gem."
1513

1614
s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"]

spec/gemfiles/Gemfile.rails-5.2.x

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ source "https://rubygems.org"
22
gemspec :path => "./../.."
33

44
gem 'pg', platform: :ruby
5-
gem 'activerecord-jdbcpostgresql-adapter', platform: :jruby
65

76
gem "jquery-rails"
87

spec/gemfiles/Gemfile.rails-6.0.x

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ source "https://rubygems.org"
22
gemspec :path => "./../.."
33

44
gem 'pg', platform: :ruby
5-
gem 'activerecord-jdbcpostgresql-adapter', "~> 60.0", platform: :jruby
65

76
gem "jquery-rails"
87

0 commit comments

Comments
 (0)