[iOS] 3.0.0 build error on old arch

[huschu]

I had to upgrade to version 3.0.0 because my EAS builds had this issue, even though I haven't enabled the new architecture yet. But now on my local machine these commands fail:

CompileC [...]/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-clusterer.build/Objects-normal/arm64/react-native-clusterer.o [...]/node_modules/react-native-clusterer/cpp/react-native-clusterer.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-clusterer' from project 'Pods')
CompileC [...]/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-clusterer.build/Objects-normal/arm64/helpers.o [...]/node_modules/react-native-clusterer/cpp/helpers.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-clusterer' from project 'Pods')

When I bump the c++ dialect in Xcode it builds, but of course with every prebuild that setting is lost. I don't know much about c++ or pods, but is there a way to set this permanently?

[SamuelPoulin]

Thanks for this fix, setting it to C++20 also resolved my issue temporarily..

[sparethme]

also experiencing this, this is the only work around that worked for me... thanks for sharing @huschu

[JiriHoffmann]

I was unable to replicate it on a brand new app created with expo-cli using react native v0.76.3 and new arch disabled. Could you provide more details about your environment or create a repo with the issue?

Here is a patch-package diff that you can use to fix the issue in the meantime. It's using c++17 (which I believe should be sufficient) but you can also replace it with c++20.

react-native-clusterer+3.0.0.patch

--- a/node_modules/react-native-clusterer/ios/Clusterer.xcodeproj/project.pbxproj
+++ b/node_modules/react-native-clusterer/ios/Clusterer.xcodeproj/project.pbxproj
@@ -122,7 +122,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
+				CLANG_CXX_LANGUAGE_STANDARD = "c++17";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
@@ -172,7 +172,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
+				CLANG_CXX_LANGUAGE_STANDARD = "c++17";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;

[kdvmgn]

It all depends on the ruby version and config you have on your machine. The patch above won't work because pod install is going to overwrite it. You need to patch react-native-clusterer.podspec file.

--- a/node_modules/react-native-clusterer/react-native-clusterer.podspec
+++ b/node_modules/react-native-clusterer/react-native-clusterer.podspec
@@ -16,4 +16,9 @@ Pod::Spec.new do |s|
   s.source_files = "ios/**/*.{h,m,mm}", "cpp/**/*.{h,cpp,hpp}"
 
   s.dependency "React-Core"
+
+  s.xcconfig = {
+      "CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
+      "CLANG_CXX_LIBRARY" => "libc++"
+  }
 end