Skip to content

Commit cedfacb

Browse files
committed
update unit tests
1 parent 7b35c85 commit cedfacb

File tree

2 files changed

+18
-5
lines changed

2 files changed

+18
-5
lines changed

netty/src/test/java/io/grpc/netty/NettyServerHandlerTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
import io.netty.channel.ChannelFuture;
7979
import io.netty.channel.ChannelHandlerContext;
8080
import io.netty.channel.ChannelPromise;
81+
import io.netty.handler.codec.http.HttpHeaderNames;
8182
import io.netty.handler.codec.http2.DefaultHttp2Headers;
8283
import io.netty.handler.codec.http2.Http2CodecUtil;
8384
import io.netty.handler.codec.http2.Http2Error;
@@ -542,7 +543,8 @@ public void headersWithInvalidMethodShouldFail() throws Exception {
542543
.set(InternalStatus.CODE_KEY.name(), String.valueOf(Code.INTERNAL.value()))
543544
.set(InternalStatus.MESSAGE_KEY.name(), "Method 'FAKE' is not supported")
544545
.status("" + 405)
545-
.set(CONTENT_TYPE_HEADER, "text/plain; charset=utf-8");
546+
.set(CONTENT_TYPE_HEADER, "text/plain; charset=utf-8")
547+
.set(HttpHeaderNames.ALLOW, HTTP_METHOD);
546548

547549
verifyWrite()
548550
.writeHeaders(

okhttp/src/test/java/io/grpc/okhttp/OkHttpServerTransportTest.java

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import static org.mockito.Mockito.timeout;
3535
import static org.mockito.Mockito.verify;
3636

37+
import com.google.common.collect.Lists;
3738
import com.google.common.io.ByteStreams;
3839
import io.grpc.Attributes;
3940
import io.grpc.InternalChannelz.SocketStats;
@@ -62,6 +63,7 @@
6263
import java.util.ArrayDeque;
6364
import java.util.ArrayList;
6465
import java.util.Arrays;
66+
import java.util.Collections;
6567
import java.util.Deque;
6668
import java.util.List;
6769
import java.util.concurrent.CountDownLatch;
@@ -919,8 +921,9 @@ public void httpGet_failsWith405() throws Exception {
919921
CONTENT_TYPE_HEADER,
920922
TE_HEADER));
921923
clientFrameWriter.flush();
922-
923-
verifyHttpError(1, 405, Status.Code.INTERNAL, "HTTP Method is not supported: GET");
924+
List<Header> extraHeaders = Lists.newArrayList(new Header("allow", "POST"));
925+
verifyHttpError(1, 405, Status.Code.INTERNAL, "HTTP Method is not supported: GET",
926+
extraHeaders);
924927

925928
shutdownAndTerminate(/*lastStreamId=*/ 1);
926929
}
@@ -976,7 +979,8 @@ public void httpErrorsAdhereToFlowControl() throws Exception {
976979
new Header(":status", "405"),
977980
new Header("content-type", "text/plain; charset=utf-8"),
978981
new Header("grpc-status", "" + Status.Code.INTERNAL.value()),
979-
new Header("grpc-message", errorDescription));
982+
new Header("grpc-message", errorDescription),
983+
new Header("allow", "POST"));
980984
assertThat(clientFrameReader.nextFrame(clientFramesRead)).isTrue();
981985
verify(clientFramesRead)
982986
.headers(false, false, 1, -1, responseHeaders, HeadersMode.HTTP_20_HEADERS);
@@ -1398,11 +1402,18 @@ private void pingPong() throws IOException {
13981402

13991403
private void verifyHttpError(
14001404
int streamId, int httpCode, Status.Code grpcCode, String errorDescription) throws Exception {
1401-
List<Header> responseHeaders = Arrays.asList(
1405+
verifyHttpError(streamId, httpCode, grpcCode, errorDescription, Collections.emptyList());
1406+
}
1407+
1408+
private void verifyHttpError(
1409+
int streamId, int httpCode, Status.Code grpcCode, String errorDescription,
1410+
List<Header> extraHeaders) throws Exception {
1411+
List<Header> responseHeaders = Lists.newArrayList(
14021412
new Header(":status", "" + httpCode),
14031413
new Header("content-type", "text/plain; charset=utf-8"),
14041414
new Header("grpc-status", "" + grpcCode.value()),
14051415
new Header("grpc-message", errorDescription));
1416+
responseHeaders.addAll(extraHeaders);
14061417
assertThat(clientFrameReader.nextFrame(clientFramesRead)).isTrue();
14071418
verify(clientFramesRead)
14081419
.headers(false, false, streamId, -1, responseHeaders, HeadersMode.HTTP_20_HEADERS);

0 commit comments

Comments
 (0)