Skip to content

Commit 701d80a

Browse files
committed
Simplify krew manifest naming to oadp.yaml
🎯 Perfect for krew index submission: - Generate oadp.yaml directly (not oadp-final.yaml) - Release artifact is ready to drop into krew index - No renaming needed - matches krew convention exactly - Clean workflow: template → envsubst → oadp.yaml
1 parent 004439a commit 701d80a

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,9 @@ jobs:
108108
fi
109109
110110
# Use envsubst to substitute environment variables in template
111-
envsubst < oadp.yaml > kubectl-oadp.yaml
111+
# Save original template and generate final manifest
112+
cp oadp.yaml oadp-template.yaml
113+
envsubst < oadp-template.yaml > oadp.yaml
112114
113115
echo "✅ Final krew manifest generated successfully!"
114116
echo ""
@@ -123,15 +125,15 @@ jobs:
123125
124126
echo ""
125127
echo "Final manifest preview:"
126-
grep -E "(version:|sha256:)" kubectl-oadp.yaml
128+
grep -E "(version:|sha256:)" oadp.yaml
127129
128130
- name: Create GitHub Release
129131
uses: softprops/action-gh-release@v1
130132
with:
131133
files: |
132134
*.tar.gz
133135
checksums.txt
134-
kubectl-oadp.yaml
136+
oadp.yaml
135137
body: |
136138
## OADP CLI ${{ github.ref_name }}
137139
@@ -146,8 +148,8 @@ jobs:
146148
147149
#### Via krew manifest (for testing or custom indexes)
148150
```bash
149-
curl -LO https://github.com/migtools/oadp-cli/releases/download/${{ github.ref_name }}/kubectl-oadp.yaml
150-
kubectl krew install --manifest=kubectl-oadp.yaml
151+
curl -LO https://github.com/migtools/oadp-cli/releases/download/${{ github.ref_name }}/oadp.yaml
152+
kubectl krew install --manifest=oadp.yaml
151153
```
152154
153155
#### Manual installation
@@ -164,10 +166,10 @@ jobs:
164166
### Files Included
165167
- **Binary archives**: Platform-specific kubectl-oadp binaries with LICENSE
166168
- **checksums.txt**: SHA256 checksums for all binaries
167-
- **kubectl-oadp.yaml**: Final krew plugin manifest with populated SHA256 values
169+
- **oadp.yaml**: Final krew plugin manifest with populated SHA256 values (ready for krew index)
168170
169171
### For Krew Index Maintainers
170-
The `kubectl-oadp.yaml` file contains the complete krew plugin manifest with all SHA256 checksums populated and can be used directly for krew index submissions.
172+
The `oadp.yaml` file contains the complete krew plugin manifest with all SHA256 checksums populated and can be used directly for krew index submissions.
171173
draft: false
172174
prerelease: false
173175
env:

0 commit comments

Comments
 (0)