chore: wip

JoeyMckenzie · JoeyMckenzie · commit 36b7dacd9b35 · 2025-06-03T12:17:27.000-07:00
diff --git a/app/Http/Controllers/Auth/AuthenticatedSessionController.php b/app/Http/Controllers/Auth/AuthenticatedSessionController.php
@@ -4,7 +4,6 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use App\Http\Requests\Auth\LoginRequest;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
@@ -13,7 +12,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class AuthenticatedSessionController extends Controller
+final class AuthenticatedSessionController
 {
     /**
      * Show the login page.
diff --git a/app/Http/Controllers/Auth/ConfirmablePasswordController.php b/app/Http/Controllers/Auth/ConfirmablePasswordController.php
@@ -4,7 +4,6 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
@@ -13,7 +12,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class ConfirmablePasswordController extends Controller
+final class ConfirmablePasswordController
 {
     /**
      * Show the confirm password page.
diff --git a/app/Http/Controllers/Auth/EmailVerificationNotificationController.php b/app/Http/Controllers/Auth/EmailVerificationNotificationController.php
@@ -4,12 +4,11 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 
-final class EmailVerificationNotificationController extends Controller
+final class EmailVerificationNotificationController
 {
     /**
      * Send a new email verification notification.
diff --git a/app/Http/Controllers/Auth/EmailVerificationPromptController.php b/app/Http/Controllers/Auth/EmailVerificationPromptController.php
@@ -4,14 +4,13 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class EmailVerificationPromptController extends Controller
+final class EmailVerificationPromptController
 {
     /**
      * Show the email verification prompt page.
diff --git a/app/Http/Controllers/Auth/NewPasswordController.php b/app/Http/Controllers/Auth/NewPasswordController.php
@@ -4,7 +4,6 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Auth\Events\PasswordReset;
 use Illuminate\Http\RedirectResponse;
@@ -17,7 +16,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class NewPasswordController extends Controller
+final class NewPasswordController
 {
     /**
      * Show the password reset page.
diff --git a/app/Http/Controllers/Auth/PasswordResetLinkController.php b/app/Http/Controllers/Auth/PasswordResetLinkController.php
@@ -4,14 +4,13 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Password;
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class PasswordResetLinkController extends Controller
+final class PasswordResetLinkController
 {
     /**
      * Show the password reset link request page.
diff --git a/app/Http/Controllers/Auth/RegisteredUserController.php b/app/Http/Controllers/Auth/RegisteredUserController.php
@@ -4,7 +4,6 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Auth\Events\Registered;
 use Illuminate\Http\RedirectResponse;
@@ -16,7 +15,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class RegisteredUserController extends Controller
+final class RegisteredUserController
 {
     /**
      * Handle an incoming registration request.
diff --git a/app/Http/Controllers/Auth/VerifyEmailController.php b/app/Http/Controllers/Auth/VerifyEmailController.php
@@ -4,13 +4,12 @@
 
 namespace App\Http\Controllers\Auth;
 
-use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Auth\Events\Verified;
 use Illuminate\Foundation\Auth\EmailVerificationRequest;
 use Illuminate\Http\RedirectResponse;
 
-final class VerifyEmailController extends Controller
+final class VerifyEmailController
 {
     /**
      * Mark the authenticated user's email address as verified.
diff --git a/app/Http/Controllers/Settings/PasswordController.php b/app/Http/Controllers/Settings/PasswordController.php
@@ -4,7 +4,6 @@
 
 namespace App\Http\Controllers\Settings;
 
-use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
@@ -13,7 +12,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class PasswordController extends Controller
+final class PasswordController
 {
     /**
      * Show the user's password settings page.
diff --git a/app/Http/Controllers/Settings/ProfileController.php b/app/Http/Controllers/Settings/ProfileController.php
@@ -4,7 +4,6 @@
 
 namespace App\Http\Controllers\Settings;
 
-use App\Http\Controllers\Controller;
 use App\Http\Requests\Settings\ProfileUpdateRequest;
 use App\Models\User;
 use Illuminate\Contracts\Auth\MustVerifyEmail;
@@ -16,7 +15,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-final class ProfileController extends Controller
+final class ProfileController
 {
     /**
      * Show the user's profile settings page.
diff --git a/app/Support/StylisticEslintFormatter.php b/app/Support/StylisticEslintFormatter.php
@@ -4,23 +4,17 @@
 
 namespace App\Support;
 
-use RuntimeException;
+use Illuminate\Support\Facades\Process;
 use Spatie\TypeScriptTransformer\Formatters\Formatter;
 
 final class StylisticEslintFormatter implements Formatter
 {
     public function format(string $file): void
     {
-        exec('npm run lint:fix', $output, $resultCode);
+        $process = Process::run('npm run lint:fix');
 
-        if ($resultCode !== 0) {
-            throw new RuntimeException(
-                sprintf(
-                    'Failed to format file %s. Output: %s',
-                    $file,
-                    implode("\n", $output)
-                )
-            );
+        if ($process->failed()) {
+            $process->throw();
         }
     }
 }
diff --git a/peck.json b/peck.json
@@ -9,15 +9,16 @@
             "dropdown",
             "js",
             "filesystems",
-            "eslint"
+            "eslint",
+            "artisense",
+            "debugbar"
         ],
         "paths": [
             "tests",
             "tsconfig.json",
             "resources/js/components/ui",
             "public/favicon.svg",
-            "public/favicon.ico",
-            "storage/debugbar"
+            "public/favicon.ico"
         ]
     }
 }
diff --git a/tests/ArchTest.php b/tests/ArchTest.php
@@ -9,7 +9,11 @@
 arch()->preset()->laravel();
 arch()->preset()->php();
 arch()->preset()->security();
-arch()->preset()->strict();
+
+arch('Types and equality are strict')
+    ->expect('App\\')
+    ->toUseStrictTypes()
+    ->toUseStrictEquality();
 
 arch('Rules should be suffixed with rule', fn (): \Pest\Arch\Contracts\ArchExpectation => expect('App\Http\Rules')
     ->classes()
