chore: update profile tests

JoeyMckenzie · JoeyMckenzie · commit 4d1d2c23d09c · 2025-05-14T20:27:23.000-07:00
diff --git a/app/Http/Controllers/Auth/RegisteredUserController.php b/app/Http/Controllers/Auth/RegisteredUserController.php
@@ -26,15 +26,17 @@ final class RegisteredUserController extends Controller
     public function store(Request $request): RedirectResponse
     {
         $request->validate([
-            'name' => 'required|string|max:255',
+            'first_name' => 'required|string|max:255',
+            'last_name' => 'required|string|max:255',
             'email' => 'required|string|lowercase|email|max:255|unique:'.User::class,
             'password' => ['required', 'confirmed', Rules\Password::defaults()],
         ]);
 
         /** @var string $password */
         $password = $request->password;
         $user = User::create([
-            'name' => $request->name,
+            'first_name' => $request->first_name,
+            'last_name' => $request->last_name,
             'email' => $request->email,
             'password' => Hash::make($password),
         ]);
diff --git a/app/Http/Requests/Settings/ProfileUpdateRequest.php b/app/Http/Requests/Settings/ProfileUpdateRequest.php
@@ -19,7 +19,8 @@ final class ProfileUpdateRequest extends FormRequest
     public function rules(): array
     {
         return [
-            'name' => ['required', 'string', 'max:255'],
+            'first_name' => ['required', 'string', 'max:255'],
+            'last_name' => ['required', 'string', 'max:255'],
             'email' => [
                 'required',
                 'string',
diff --git a/bin/ci b/bin/ci
@@ -80,7 +80,7 @@ fi
 
 info "Running frontend CI checks..."
 
-npm run check
+npm run lint
 
 info "Building assets..."
 
diff --git a/composer.json b/composer.json
@@ -87,7 +87,7 @@
         "test:ci": "vendor/bin/pest --mutate --min=100 --parallel --ci",
         "test": [
             "@php artisan config:clear --ansi",
-            "vendor/bin/pest"
+            "@test:unit"
         ],
         "test:all": [
             "@test",
@@ -114,7 +114,7 @@
             "@lint",
             "@fmt:test",
             "@refactor:test",
-            "@test",
+            "@test:all",
             "@typos"
         ],
         "transform": "php artisan typescript:transform --format",
diff --git a/phpunit.xml b/phpunit.xml
@@ -11,6 +11,9 @@
         <testsuite name="Feature">
             <directory>tests/Feature</directory>
         </testsuite>
+        <testsuite name="Arch">
+            <directory suffix="ArchTest.php">tests</directory>
+        </testsuite>
     </testsuites>
     <source>
         <include>
diff --git a/resources/js/pages/auth/Register.vue b/resources/js/pages/auth/Register.vue
@@ -1,4 +1,4 @@
-<script setup lang="ts">
+<script lang="ts" setup>
 import { Head, useForm } from "@inertiajs/vue3";
 import { LoaderCircle } from "lucide-vue-next";
 import InputError from "@/components/InputError.vue";
@@ -9,7 +9,8 @@ import { Label } from "@/components/ui/label";
 import AuthBase from "@/layouts/AuthLayout.vue";
 
 const form = useForm({
-    name: "",
+    first_name: "",
+    last_name: "",
     email: "",
     password: "",
     password_confirmation: "",
@@ -23,20 +24,44 @@ function submit() {
 </script>
 
 <template>
-    <AuthBase title="Create an account" description="Enter your details below to create your account">
+    <AuthBase description="Enter your details below to create your account" title="Create an account">
         <Head title="Register" />
 
         <form class="flex flex-col gap-6" @submit.prevent="submit">
             <div class="grid gap-6">
                 <div class="grid gap-2">
-                    <Label for="name">Name</Label>
-                    <Input id="name" v-model="form.name" type="text" required autofocus :tabindex="1" autocomplete="name" placeholder="Full name" />
-                    <InputError :message="form.errors.name" />
+                    <Label for="first_name">First name</Label>
+                    <Input
+                        id="first_name" v-model="form.first_name"
+                        :tabindex="1"
+                        autocomplete="first_name"
+                        autofocus
+                        placeholder="First name"
+                        required type="text"
+                    />
+                    <InputError :message="form.errors.first_name" />
+                </div>
+
+                <div class="grid gap-2">
+                    <Label for="last_name">Last name</Label>
+                    <Input
+                        id="last_name" v-model="form.last_name"
+                        :tabindex="1"
+                        autocomplete="last_name"
+                        autofocus
+                        placeholder="Last name"
+                        required type="text"
+                    />
+                    <InputError :message="form.errors.last_name" />
                 </div>
 
                 <div class="grid gap-2">
                     <Label for="email">Email address</Label>
-                    <Input id="email" v-model="form.email" type="email" required :tabindex="2" autocomplete="email" placeholder="email@example.com" />
+                    <Input
+                        id="email" v-model="form.email" :tabindex="2" autocomplete="email"
+                        placeholder="email@example.com" required
+                        type="email"
+                    />
                     <InputError :message="form.errors.email" />
                 </div>
 
@@ -45,11 +70,11 @@ function submit() {
                     <Input
                         id="password"
                         v-model="form.password"
-                        type="password"
-                        required
                         :tabindex="3"
                         autocomplete="new-password"
                         placeholder="Password"
+                        required
+                        type="password"
                     />
                     <InputError :message="form.errors.password" />
                 </div>
@@ -59,24 +84,24 @@ function submit() {
                     <Input
                         id="password_confirmation"
                         v-model="form.password_confirmation"
-                        type="password"
-                        required
                         :tabindex="4"
                         autocomplete="new-password"
                         placeholder="Confirm password"
+                        required
+                        type="password"
                     />
                     <InputError :message="form.errors.password_confirmation" />
                 </div>
 
-                <Button type="submit" class="mt-2 w-full" tabindex="5" :disabled="form.processing">
+                <Button :disabled="form.processing" class="mt-2 w-full" tabindex="5" type="submit">
                     <LoaderCircle v-if="form.processing" class="h-4 w-4 animate-spin" />
                     Create account
                 </Button>
             </div>
 
             <div class="text-muted-foreground text-center text-sm">
                 Already have an account?
-                <TextLink :href="route('login')" class="underline underline-offset-4" :tabindex="6">
+                <TextLink :href="route('login')" :tabindex="6" class="underline underline-offset-4">
                     Log in
                 </TextLink>
             </div>
diff --git a/resources/js/pages/settings/Profile.vue b/resources/js/pages/settings/Profile.vue
@@ -29,7 +29,8 @@ const page = usePage<SharedData>();
 const user = page.props.auth.user as App.Data.UserData;
 
 const form = useForm({
-    name: user.fullName,
+    first_name: user.firstName,
+    last_name: user.lastName,
     email: user.email,
 });
 
@@ -49,14 +50,32 @@ function submit() {
                 <HeadingSmall description="Update your name and email address" title="Profile information" />
 
                 <form class="space-y-6" @submit.prevent="submit">
-                    <div class="grid gap-2">
-                        <Label for="name">Name</Label>
-                        <Input
-                            id="name" v-model="form.name" autocomplete="name" class="mt-1 block w-full"
-                            placeholder="Full name"
-                            required
-                        />
-                        <InputError :message="form.errors.name" class="mt-2" />
+                    <div class="grid grid-cols-2 gap-6">
+                        <div class="grid gap-2">
+                            <Label for="first_name">First name</Label>
+                            <Input
+                                id="first_name"
+                                v-model="form.first_name"
+                                autocomplete="first_name"
+                                class="mt-1 block w-full"
+                                placeholder="First name"
+                                required
+                            />
+                            <InputError :message="form.errors.first_name" class="mt-2" />
+                        </div>
+
+                        <div class="grid gap-2">
+                            <Label for="last_name">Last name</Label>
+                            <Input
+                                id="name"
+                                v-model="form.last_name"
+                                autocomplete="last_name"
+                                class="mt-1 block w-full"
+                                placeholder="Last name"
+                                required
+                            />
+                            <InputError :message="form.errors.last_name" class="mt-2" />
+                        </div>
                     </div>
 
                     <div class="grid gap-2">
diff --git a/tests/ArchTest.php b/tests/ArchTest.php
@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests;
+
+use Illuminate\Contracts\Validation\ValidationRule;
+
+arch()->preset()->laravel();
+
+arch('Rules should be suffixed with rule', fn (): \Pest\Arch\Contracts\ArchExpectation => expect('App\Http\Rules')
+    ->classes()
+    ->toBeFinal()
+    ->toHaveSuffix('Rule')
+    ->toImplement(ValidationRule::class));
+
+arch('All test files are strictly typed')
+    ->expect('Tests\\')
+    ->toUseStrictTypes();
+
+arch('All enums are string backed')
+    ->expect('App\\Enums\\')
+    ->toBeStringBackedEnums();
+
+arch('All value objects are immutable')
+    ->expect('App\\ValueObjects\\')
+    ->toBeReadonly()
+    ->and('App\\ValueObjects')
+    ->toBeFinal();
+
+arch('All contracts are interfaces')
+    ->expect('App\\Contracts\\')
+    ->toBeInterfaces();
diff --git a/tests/Feature/Auth/RegistrationTest.php b/tests/Feature/Auth/RegistrationTest.php
@@ -12,7 +12,8 @@
 
 it('allows new users to register', function (): void {
     $response = $this->post('/register', [
-        'name' => 'Test User',
+        'first_name' => 'Test',
+        'last_name' => 'User',
         'email' => 'test@example.com',
         'password' => 'password',
         'password_confirmation' => 'password',
diff --git a/tests/Feature/DashboardTest.php b/tests/Feature/DashboardTest.php
@@ -6,15 +6,17 @@
 
 use App\Models\User;
 
-it('redirects guests to the login page', function (): void {
-    $response = $this->get('/dashboard');
-    $response->assertRedirect('/login');
-});
+describe('Dashboard', function (): void {
+    it('redirects guests to the login page', function (): void {
+        $response = $this->get('/dashboard');
+        $response->assertRedirect('/login');
+    });
 
-it('allows authenticated users to visit the dashboard', function (): void {
-    $user = User::factory()->create();
-    $this->actingAs($user);
+    it('allows authenticated users to visit the dashboard', function (): void {
+        $user = User::factory()->create();
+        $this->actingAs($user);
 
-    $response = $this->get('/dashboard');
-    $response->assertStatus(200);
+        $response = $this->get('/dashboard');
+        $response->assertStatus(200);
+    });
 });
diff --git a/tests/Feature/ExampleTest.php b/tests/Feature/ExampleTest.php
diff --git a/tests/Feature/Settings/PasswordUpdateTest.php b/tests/Feature/Settings/PasswordUpdateTest.php
@@ -7,38 +7,40 @@
 use App\Models\User;
 use Illuminate\Support\Facades\Hash;
 
-it('can update password', function (): void {
-    $user = User::factory()->create();
-
-    $response = $this
-        ->actingAs($user)
-        ->from('/settings/password')
-        ->put('/settings/password', [
-            'current_password' => 'password',
-            'password' => 'new-password',
-            'password_confirmation' => 'new-password',
-        ]);
-
-    $response
-        ->assertSessionHasNoErrors()
-        ->assertRedirect('/settings/password');
-
-    $this->assertTrue(Hash::check('new-password', $user->refresh()->password));
-});
-
-it('requires correct current password to update password', function (): void {
-    $user = User::factory()->create();
-
-    $response = $this
-        ->actingAs($user)
-        ->from('/settings/password')
-        ->put('/settings/password', [
-            'current_password' => 'wrong-password',
-            'password' => 'new-password',
-            'password_confirmation' => 'new-password',
-        ]);
-
-    $response
-        ->assertSessionHasErrors('current_password')
-        ->assertRedirect('/settings/password');
+describe('Password updates', function (): void {
+    it('can update password', function (): void {
+        $user = User::factory()->create();
+
+        $response = $this
+            ->actingAs($user)
+            ->from('/settings/password')
+            ->put('/settings/password', [
+                'current_password' => 'password',
+                'password' => 'new-password',
+                'password_confirmation' => 'new-password',
+            ]);
+
+        $response
+            ->assertSessionHasNoErrors()
+            ->assertRedirect('/settings/password');
+
+        $this->assertTrue(Hash::check('new-password', $user->refresh()->password));
+    });
+
+    it('requires correct current password to update password', function (): void {
+        $user = User::factory()->create();
+
+        $response = $this
+            ->actingAs($user)
+            ->from('/settings/password')
+            ->put('/settings/password', [
+                'current_password' => 'wrong-password',
+                'password' => 'new-password',
+                'password_confirmation' => 'new-password',
+            ]);
+
+        $response
+            ->assertSessionHasErrors('current_password')
+            ->assertRedirect('/settings/password');
+    });
 });
diff --git a/tests/Feature/Settings/ProfileUpdateTest.php b/tests/Feature/Settings/ProfileUpdateTest.php
