fix: resolve compilation errors in workflows

- Add gorilla/websocket dependency and imports
- Fix CategoryRetryConfig type conflicts between packages
- Remove duplicate OptimizedClientConfig definitions
- Add missing TryRecoverFromError method to ErrorAwareClient
- Clean up unused imports in websocket and broadcaster files

Author: JohanDevl

go.mod

@@ -30,6 +30,7 @@ require (
 	github.com/go-logr/logr v1.4.2 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/godbus/dbus/v5 v5.1.0 // indirect
+	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/kylelemons/godebug v1.1.0 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect

go.sum

@@ -24,6 +24,8 @@ github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 h1:El6M4kTTCOh6aBiKaU
 github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
 github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
 github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
+github.com/gorilla/websocket v1.5.3 h1:saDtZ6Pbx/0u+bgYQ3q96pZgCzfhKXGPqt7kZ72aNNg=
+github.com/gorilla/websocket v1.5.3/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
 github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo=
 github.com/klauspost/compress v1.18.0/go.mod h1:2Pp+KzxcywXVXMr50+X0Q/Lsb43OQHYWRCY2AiWywWQ=
 github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=

pkg/api/error_aware_client.go

@@ -128,6 +128,24 @@ func (eac *ErrorAwareClient) Close() error {
 	return nil
 }
 
+// TryRecoverFromError attempts to recover from an error using the error manager
+func (eac *ErrorAwareClient) TryRecoverFromError(ctx context.Context, err error) error {
+	if eac.errorManager == nil {
+		return err
+	}
+	
+	// Convert to AppError if needed
+	var appErr *types.AppError
+	if ae, ok := err.(*types.AppError); ok {
+		appErr = ae
+	} else {
+		appErr = types.NewAppError(types.ErrOperationFailed, err.Error(), err)
+	}
+	
+	// Try recovery
+	return eac.errorManager.TryRecover(ctx, appErr)
+}
+
 // ErrorAwareOptimizedClient wraps OptimizedTraktAPIClient with unified error handling
 type ErrorAwareOptimizedClient struct {
 	client       OptimizedTraktAPIClient

pkg/api/factory.go

@@ -60,29 +60,12 @@ func (f *DefaultClientFactory) CreateBasicClient(cfg *config.Config) (TraktAPICl
 // CreateOptimizedClient creates an optimized Trakt API client
 func (f *DefaultClientFactory) CreateOptimizedClient(cfg OptimizedClientConfig) (OptimizedTraktAPIClient, error) {
 	// Validate configuration
-	if cfg.BaseConfig == nil {
+	if cfg.Config == nil {
 		return nil, fmt.Errorf("base configuration cannot be nil")
 	}
 
-	// Set defaults for optimized client config
-	optimizedConfig := OptimizedClientConfig{
-		Config:           cfg.BaseConfig,
-		Logger:           cfg.Logger,
-		WorkerPoolSize:   cfg.WorkerPoolSize,
-		RateLimitPerSec:  cfg.RateLimitPerSec,
-		ConnectionPool:   cfg.ConnectionPool,
-		RequestTimeout:   cfg.RequestTimeout,
-	}
-
-	// Set cache config defaults
-	if cfg.CacheConfig != nil {
-		optimizedConfig.CacheConfig = *cfg.CacheConfig
-	} else {
-		optimizedConfig.CacheConfig = cache.CacheConfig{
-			Capacity: 1000,
-			TTL:      24 * time.Hour,
-		}
-	}
+	// Configuration is already complete - just create the client
+	optimizedConfig := cfg
 
 	// Create optimized client
 	client := NewOptimizedClient(optimizedConfig)
@@ -106,11 +89,21 @@ func (f *DefaultClientFactory) CreateClientWithCapabilities(cfg ClientCapabiliti
 
 	// If advanced capabilities are requested, create optimized client
 	if cfg.EnableCaching || cfg.EnableMetrics || cfg.EnableConcurrency || cfg.WorkerPoolSize > 0 {
+		var cacheConfig cache.CacheConfig
+		if cfg.CacheConfig != nil {
+			cacheConfig = *cfg.CacheConfig
+		} else {
+			cacheConfig = cache.CacheConfig{
+				Capacity: 1000,
+				TTL:      24 * time.Hour,
+			}
+		}
+
 		optimizedConfig := OptimizedClientConfig{
-			BaseConfig:       cfg.BaseConfig,
+			Config:           cfg.BaseConfig,
 			Logger:           nil, // Would need to be provided
 			WorkerPoolSize:   cfg.WorkerPoolSize,
-			CacheConfig:      cfg.CacheConfig,
+			CacheConfig:      cacheConfig,
 		}
 
 		if cfg.WorkerPoolSize <= 0 {
@@ -124,14 +117,3 @@ func (f *DefaultClientFactory) CreateClientWithCapabilities(cfg ClientCapabiliti
 	return f.CreateBasicClient(cfg.BaseConfig)
 }
 
-// OptimizedClientConfig represents the configuration for optimized clients
-// This extends the interface definition with implementation details
-type OptimizedClientConfig struct {
-	BaseConfig       *config.Config
-	Logger           logger.Logger
-	CacheConfig      cache.CacheConfig
-	WorkerPoolSize   int
-	RateLimitPerSec  int
-	ConnectionPool   int
-	RequestTimeout   time.Duration
-}

pkg/api/unified_example.go

@@ -38,7 +38,7 @@ func UnifiedAPIExample() error {
 
 	// 6. Create an optimized client
 	optimizedConfig := OptimizedClientConfig{
-		BaseConfig:       cfg,
+		Config:           cfg,
 		Logger:           log,
 		WorkerPoolSize:   10,
 		RateLimitPerSec:  100,

pkg/errors/handlers/config.go

@@ -0,0 +1,13 @@
+package handlers
+
+import "time"
+
+// CategoryRetryConfig defines retry configuration per error category
+type CategoryRetryConfig struct {
+	MaxAttempts   int
+	InitialDelay  time.Duration
+	MaxDelay      time.Duration
+	BackoffFactor float64
+	EnableJitter  bool
+	CircuitBreaker bool
+}

pkg/errors/handlers/network.go

@@ -16,15 +16,6 @@ type NetworkErrorHandler struct {
 	Config *CategoryRetryConfig
 }
 
-// CategoryRetryConfig defines retry configuration per error category
-type CategoryRetryConfig struct {
-	MaxAttempts     int
-	InitialDelay    time.Duration
-	MaxDelay        time.Duration
-	BackoffFactor   float64
-	EnableJitter    bool
-	CircuitBreaker  bool
-}
 
 // NewNetworkErrorHandler creates a new network error handler
 func NewNetworkErrorHandler(logger logger.Logger, config *CategoryRetryConfig) *NetworkErrorHandler {

pkg/errors/manager.go

@@ -411,21 +411,24 @@ func (em *ErrorManager) defaultHandle(ctx context.Context, err *types.AppError)
 // initializeDefaultHandlers sets up default error handlers
 func (em *ErrorManager) initializeDefaultHandlers() {
 	// Network errors handler
+	networkConfig := em.config.RetryConfig.PerCategoryConfig[types.CategoryNetwork]
 	em.handlers[types.CategoryNetwork] = &handlers.NetworkErrorHandler{
 		Logger: em.logger,
-		Config: em.config.RetryConfig.PerCategoryConfig[types.CategoryNetwork],
+		Config: convertToHandlerConfig(networkConfig),
 	}
 
 	// Authentication errors handler
+	authConfig := em.config.RetryConfig.PerCategoryConfig[types.CategoryAuthentication]
 	em.handlers[types.CategoryAuthentication] = &handlers.AuthErrorHandler{
 		Logger: em.logger,
-		Config: em.config.RetryConfig.PerCategoryConfig[types.CategoryAuthentication],
+		Config: convertToHandlerConfig(authConfig),
 	}
 
 	// Operation errors handler
+	opConfig := em.config.RetryConfig.PerCategoryConfig[types.CategoryOperation]
 	em.handlers[types.CategoryOperation] = &handlers.OperationErrorHandler{
 		Logger: em.logger,
-		Config: em.config.RetryConfig.PerCategoryConfig[types.CategoryOperation],
+		Config: convertToHandlerConfig(opConfig),
 	}
 }
 
@@ -457,4 +460,20 @@ func contains(s string, substrings ...string) bool {
 		}
 	}
 	return false
+}
+
+// convertToHandlerConfig converts CategoryRetryConfig to handlers.CategoryRetryConfig
+func convertToHandlerConfig(config *CategoryRetryConfig) *handlers.CategoryRetryConfig {
+	if config == nil {
+		return nil
+	}
+	
+	return &handlers.CategoryRetryConfig{
+		MaxAttempts:    config.MaxAttempts,
+		InitialDelay:   config.InitialDelay,
+		MaxDelay:       config.MaxDelay,
+		BackoffFactor:  config.BackoffFactor,
+		EnableJitter:   config.EnableJitter,
+		CircuitBreaker: config.CircuitBreaker,
+	}
 }

pkg/web/realtime/broadcaster.go

@@ -1,7 +1,6 @@
 package realtime
 
 import (
-	"context"
 	"encoding/json"
 	"fmt"
 	"os"

pkg/web/realtime/websocket.go

@@ -1,22 +1,20 @@
 package realtime
 
 import (
-	"bufio"
-	"crypto/sha1"
-	"encoding/base64"
 	"encoding/json"
 	"fmt"
 	"net/http"
-	"strings"
 	"time"
 
+	"github.com/gorilla/websocket"
 	"github.com/JohanDevl/Export_Trakt_4_Letterboxd/pkg/logger"
 )
 
 // WebSocketHandler handles WebSocket connections
 type WebSocketHandler struct {
-	hub    *Hub
-	logger logger.Logger
+	hub      *Hub
+	logger   logger.Logger
+	upgrader websocket.Upgrader
 }
 
 // NewWebSocketHandler creates a new WebSocket handler