Merge branch 'master' into 2023.2-urp

# Conflicts:
#	Packages/manifest.json
#	Packages/packages-lock.json
#	ProjectSettings/ProjectSettings.asset
#	ProjectSettings/ProjectVersion.txt

Author: JohannesDeml

.github/scripts/add-tags.sh

@@ -3,11 +3,14 @@
 # example usage
 # sh add-tags.sh "6000.0.0f1" -> Creates tags for non-urp version
 # sh add-tags.sh "6000.0.0f1" "true" -> Creates tags for urp version
+# sh add-tags.sh "6000.0.0f1" "true" "10" -> Creates tags for urp version with 10 second delay between pushes
 
 # Input parameters
 UNITY_VERSION=$1
 IS_URP=${2:-"false"}
-echo "Running add_tags.sh with UNITY_VERSION: $UNITY_VERSION, IS_URP: $IS_URP"
+DELAY_TAGS=${3:-"0"}
+
+echo "Running add_tags.sh with UNITY_VERSION: $UNITY_VERSION, IS_URP: $IS_URP, DELAY_TAGS: $DELAY_TAGS seconds"
 
 # Extract the value before the first dot as an integer
 MAJOR_VERSION=$(echo $UNITY_VERSION | cut -d. -f1)
@@ -19,22 +22,42 @@ then
 TAG_PREFIX=$UNITY_VERSION-urp
 fi
 
+# Build array of tags to create and push
+TAGS=()
+
 if [[ "$MAJOR_VERSION" -lt "2023" ]]
 then
-git tag -a -f $TAG_PREFIX-minsize-webgl1 -m "[Automated workflow] Created by upgrade-unity"
-git tag -a -f $TAG_PREFIX-webgl1 -m "[Automated workflow] Created by upgrade-unity"
+TAGS+=("$TAG_PREFIX-minsize-webgl1")
+TAGS+=("$TAG_PREFIX-webgl1")
 else
-git tag -a -f $TAG_PREFIX-minsize-webgl2 -m "[Automated workflow] Created by upgrade-unity"
+TAGS+=("$TAG_PREFIX-minsize-webgl2")
 fi
-# Push tags in between - pushing more than 3 tags won't trigger tag workflows
-git push origin -f --tags
 
-git tag -a -f $TAG_PREFIX-webgl2 -m "[Automated workflow] Created by upgrade-unity"
-git tag -a -f $TAG_PREFIX-webgl2-debug -m "[Automated workflow] Created by upgrade-unity"
+TAGS+=("$TAG_PREFIX-webgl2")
+TAGS+=("$TAG_PREFIX-webgl2-debug")
 
 if [[ "$MAJOR_VERSION" -ge "6000" ]]
 then
-git tag -a -f $TAG_PREFIX-webgpu -m "[Automated workflow] Created by upgrade-unity"
+TAGS+=("$TAG_PREFIX-webgpu")
 fi
 
-git push origin -f --tags
+# Loop through tags, create and push each one with delay
+for i in "${!TAGS[@]}"; do
+  TAG="${TAGS[$i]}"
+  echo "Creating and pushing tag: $TAG"
+
+  # Create the tag
+  git tag -a -f "$TAG" -m "[Automated workflow] Created by upgrade-unity"
+
+  # Push the tag
+  git push origin -f "$TAG"
+
+  # Wait between pushes if not the last tag and delay is specified
+  if [[ $i -lt $((${#TAGS[@]} - 1)) ]] && [[ "$DELAY_TAGS" -gt "0" ]]
+  then
+    echo "Waiting $DELAY_TAGS seconds before next tag push..."
+    sleep $DELAY_TAGS
+  fi
+done
+
+echo "All tags created and pushed successfully."

.github/templates/upgrade-unity-pr-body.md

@@ -5,7 +5,8 @@
 ### Built version demos
 
 * https://deml.io/experiments/unity-webgl/{{ .unityversion }}-webgl2
-* https://deml.io/experiments/unity-webgl/{{ .unityversion }}-webgl1
+* https://deml.io/experiments/unity-webgl/{{ .unityversion }}-webgl2-debug
+* https://deml.io/experiments/unity-webgl/{{ .unityversion }}-minsize-webgl2
 
 ### Other links
 

.github/workflows/release.yml

@@ -73,14 +73,24 @@ jobs:
     if: ${{ github.ref == 'refs/heads/master' || needs.variables.outputs.TAG != needs.variables.outputs.UNITY_VERSION }}
     needs: [ variables ]
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           lfs: true
 
+      # Avoid running into space issues for github runners - Docker images can take up quite some space
+      - name: Free Disk Space
+        run: |
+          echo "Disk space before cleanup:"
+          df -h
+          sudo rm -rf /usr/share/dotnet
+          sudo rm -rf /opt/ghc
+          sudo rm -rf /usr/local/share/boost
+          sudo rm -rf "$AGENT_TOOLSDIRECTORY"
+          echo "Disk space after cleanup:"
+          df -h
+
       # Unity 2020 cache is not compatible with older versions
       - name: Unity Library Cache 2020 or higher
         if: ${{ !startsWith(needs.variables.outputs.UNITY_VERSION, '201') }}
@@ -111,6 +121,17 @@ jobs:
           versioning: None
           buildName: ${{ needs.variables.outputs.BUILD_NAME }}
 
+      - name: Check Disk Space After Build
+        run: |
+          echo "Disk space after build:"
+          df -h
+          AVAILABLE=$(df / | tail -1 | awk '{print $4}')
+          AVAILABLE_GB=$(echo $AVAILABLE | sed 's/G//')
+          echo "Available space: ${AVAILABLE_GB}GB"
+          if (( $(echo "$AVAILABLE_GB < 1" | bc -l) )); then
+            echo "::warning::Low disk space! Less than 1GB remaining."
+          fi
+
       - uses: actions/upload-artifact@v4
         with:
           name: ${{ needs.variables.outputs.BUILD_NAME }}

.github/workflows/upgrade-unity.yml

@@ -29,13 +29,16 @@ on:
         required: false
         type: string
         default: '-accept-apiupdate'
+      delayTags:
+        description: 'Delay between tag pushes (in seconds, minimum 1)'
+        required: false
+        type: number
+        default: 1
 
 jobs:
   upgrade-unity-version:
     name: Upgrade Unity version and packages to ${{ inputs.unityVersion }}
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
     steps:
       - name: Log input parameter
         run: |
@@ -47,6 +50,7 @@ jobs:
           echo "Only create tags: $TAGS_ONLY"
           echo "Merge master into branch: $MERGE_MASTER"
           echo "Custom cli arguments: $CUSTOM_PARAMETERS"
+          echo "Delay tags: $DELAY_TAGS seconds"
           if [[ "$BRANCH_NAME" == *"urp"* ]]
           then
             echo "urp: true"
@@ -59,6 +63,7 @@ jobs:
           TAGS_ONLY: ${{ inputs.tagsOnly }}
           MERGE_MASTER: ${{ inputs.mergeMaster }}
           CUSTOM_PARAMETERS: ${{ inputs.customParameters }}
+          DELAY_TAGS: ${{ inputs.delayTags }}
 
       - uses: actions/checkout@v4
         with:
@@ -75,6 +80,18 @@ jobs:
         env:
           GIT_USER: ${{ github.actor }}
 
+      # Avoid running into space issues for github runners - Docker images can take up quite some space
+      - name: Free Disk Space
+        run: |
+          echo "Disk space before cleanup:"
+          df -h
+          sudo rm -rf /usr/share/dotnet
+          sudo rm -rf /opt/ghc
+          sudo rm -rf /usr/local/share/boost
+          sudo rm -rf "$AGENT_TOOLSDIRECTORY"
+          echo "Disk space after cleanup:"
+          df -h
+
       # Make sure the branch has the latest master changes in
       - name: Merge master into current branch
         if: ${{ inputs.mergeMaster }}
@@ -149,6 +166,18 @@ jobs:
           allowDirtyBuild: true
           manualExit: true
 
+      - name: Check Disk Space After Build
+        if: ${{ !inputs.tagsOnly }}
+        run: |
+          echo "Disk space after build:"
+          df -h
+          AVAILABLE=$(df / | tail -1 | awk '{print $4}')
+          AVAILABLE_GB=$(echo $AVAILABLE | sed 's/G//')
+          echo "Available space: ${AVAILABLE_GB}GB"
+          if (( $(echo "$AVAILABLE_GB < 1" | bc -l) )); then
+            echo "::warning::Low disk space! Less than 1GB remaining."
+          fi
+
       - name: Delete build folder with elevated rights
         if: ${{ !inputs.tagsOnly }}
         run: sudo rm -rf ./build
@@ -183,8 +212,9 @@ jobs:
             IS_URP=true
           fi
 
-          # Run add tags script
-          ./.github/scripts/add-tags.sh "$UNITY_VERSION" "$IS_URP"
+          # Run add tags script with delay parameter
+          ./.github/scripts/add-tags.sh "$UNITY_VERSION" "$IS_URP" "$DELAY_TAGS"
         env:
           UNITY_VERSION: ${{ inputs.unityVersion }}
+          DELAY_TAGS: ${{ inputs.delayTags }}
 

Assets/Plugins/WebGL/WebBridge/CommonCommands.cs

@@ -66,6 +66,25 @@ public void LogMemory()
 			WebToolPlugins.LogMemory();
 		}
 
+		/// <summary>
+		/// Logs the rough device memory capped between 0.25 and 8 GB
+		/// Browser Usage: <code>unityGame.SendMessage("WebGL","LogDeviceMemory");</code>
+		/// </summary>
+		[WebCommand(Description = "Logs the device memory")]
+		[ContextMenu(nameof(LogDeviceMemory))]
+		public void LogDeviceMemory()
+		{
+			float deviceMemoryInMb = WebToolPlugins.GetDeviceMemory();
+			if (deviceMemoryInMb > 0)
+			{
+				Debug.Log($"Device Memory: {deviceMemoryInMb} GB");
+			}
+			else
+			{
+				Debug.Log("Device Memory information is not available on this device or browser.");
+			}
+		}
+
 		/// <summary>
 		/// Allocate memory to test memory usage and limits
 		/// The memory will be stored in a list to prevent it from being garbage collected
@@ -192,7 +211,11 @@ public void LogInitializationTime()
 		[WebCommand(Description = "Find GameObject by name and log its components")]
 		public void FindGameObjectByName(string name)
 		{
+#if UNITY_6000_0_OR_NEWER
+			var gameObjects = GameObject.FindObjectsByType<GameObject>(FindObjectsSortMode.None).Where(go => go.name == name).ToArray();
+#else
 			var gameObjects = GameObject.FindObjectsOfType<GameObject>().Where(go => go.name == name).ToArray();
+#endif
 			if (gameObjects.Length == 0)
 			{
 				Debug.Log($"No GameObject found with the name: {name}");
@@ -359,6 +382,17 @@ public void CheckOnlineStatus()
 			Debug.Log($"<color=#4D65A4>Online Status:</color> {(isOnline ? "<color=#3bb508>Connected</color>" : "<color=#b50808>Disconnected</color>")}");
 		}
 
+		/// <summary>
+		/// Sets the CSS cursor style for the Unity canvas element.
+		/// Browser Usage: <code>unityGame.SendMessage("WebGL", "SetCursor", "pointer");</code>
+		/// </summary>
+		/// <param name="cursorName">CSS cursor value (e.g., "default", "pointer", "grab", "crosshair", "text")</param>
+		[WebCommand(Description = "Set the CSS cursor style")]
+		public void SetCursor(string cursorName)
+		{
+			WebToolPlugins.SetCursor(cursorName);
+		}
+
 		/// <summary>
 		/// Captures the current screen and saves it as a PNG file.
 		/// </summary>

Assets/Plugins/WebGL/WebBridge/WebBridge.cs

@@ -70,12 +70,14 @@ private static void AddAllWebCommands()
 		private static void SetGlobalVariables()
 		{
 			var graphicsDevice = SystemInfo.graphicsDeviceType;
-			string webGraphics = string.Empty;
+			string webGraphics;
 			switch (graphicsDevice)
 			{
+#if !UNITY_2023_1_OR_NEWER
 				case GraphicsDeviceType.OpenGLES2:
 					webGraphics = "WebGL 1";
 					break;
+#endif
 				case GraphicsDeviceType.OpenGLES3:
 					webGraphics = "WebGL 2";
 					break;

Assets/Plugins/WebGL/WebTools/EventListeners/WebEventListeners.cs

@@ -10,6 +10,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Runtime.InteropServices;
 using UnityEngine;
 
@@ -36,6 +37,7 @@ private static void OnBeforeSceneLoadRuntimeMethod()
 		}
 #endif
 
+		[Conditional("UNITY_WEBGL")]
 		public static void AddEventListener(string eventName, Action callback)
 		{
 			instance.AddEventListenerInternal(eventName, callback);
@@ -59,7 +61,7 @@ private void AddEventListenerInternal(string eventName, Action callback)
 				// Add event listener on javascript side
 				_AddJsEventListener(eventName);
 #elif UNITY_EDITOR && WEBTOOLS_LOG_CALLS
-			Debug.Log($"<color=#00CCCC>{nameof(WebEventListeners)}.{nameof(AddEventListenerInternal)} add callback for {eventName}</color>");
+			UnityEngine.Debug.Log($"<color=#00CCCC>{nameof(WebEventListeners)}.{nameof(AddEventListenerInternal)} add callback for {eventName}</color>");
 #endif
 			}
 		}

Assets/Plugins/WebGL/WebTools/WebToolPlugins.cs

@@ -35,13 +35,17 @@ public static class WebToolPlugins
 		[DllImport("__Internal")]
 		private static extern uint _GetTotalMemorySize();
 		[DllImport("__Internal")]
+		private static extern uint _GetDeviceMemorySize();
+		[DllImport("__Internal")]
 		private static extern bool _CopyToClipboard(string text);
 		[DllImport("__Internal")]
 		private static extern int _IsOnline();
 		[DllImport("__Internal")]
 		private static extern void _DownloadFile(string filename, string content);
 		[DllImport("__Internal")]
 		private static extern void _DownloadBlob(string filename, byte[] byteArray, int byteLength, string mimeType);
+		[DllImport("__Internal")]
+		private static extern void _SetCursor(string cursorName);
 
 #endif
 
@@ -191,6 +195,29 @@ public static float GetTotalMemorySize()
 #endif
 		}
 
+		/// <summary>
+		/// Get the device memory size in MB if supported by the browser
+		/// Uses navigator.deviceMemory which is supported by chromium based browsers
+		/// <see href="https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory"/>
+		/// </summary>
+		/// <returns>Size in MB or -1 if not supported</returns>
+		public static float GetDeviceMemory()
+		{
+#if UNITY_WEBGL && !UNITY_EDITOR
+			var gb = _GetDeviceMemorySize();
+			if (gb > 0)
+			{
+				return gb * 1024f; // convert to MB
+			}
+			return -1f;
+#elif UNITY_EDITOR && WEBTOOLS_LOG_CALLS
+			Debug.Log($"{nameof(WebToolPlugins)}.{nameof(GetDeviceMemory)} called");
+			return -1f;
+#else
+			return -1f;
+#endif
+		}
+
 		/// <summary>
 		/// Get the managed memory size used by the application in MB
 		/// </summary>
@@ -280,5 +307,28 @@ public static void DownloadBinaryFile(string filename, byte[] data, string mimeT
 				Debug.Log($"{nameof(WebToolPlugins)}.{nameof(DownloadBinaryFile)} called with filename: {filename}");
 			#endif
 		}
+
+		/// <summary>
+		/// Sets the CSS cursor style for the Unity canvas element.
+		/// <see href="https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/cursor"/>
+		/// </summary>
+		/// <param name="cursorName">The CSS cursor value (e.g., "pointer", "grab", "crosshair", "text", "default")</param>
+		/// <example>
+		/// <code>
+		/// // Example: Change cursor to pointer on hover
+		/// WebToolPlugins.SetCursor("pointer");
+		///
+		/// // Example: Reset to default cursor
+		/// WebToolPlugins.SetCursor("default");
+		/// </code>
+		/// </example>
+		public static void SetCursor(string cursorName)
+		{
+			#if UNITY_WEBGL && !UNITY_EDITOR
+				_SetCursor(cursorName);
+			#elif UNITY_EDITOR && WEBTOOLS_LOG_CALLS
+				Debug.Log($"{nameof(WebToolPlugins)}.{nameof(SetCursor)} called with cursor: {cursorName}");
+			#endif
+		}
 	}
 }