Merge branch 'master' of https://github.com/JohnCoene/echarts4r

JohnCoene · JohnCoene · commit ce6fd0491b2c · 2022-05-28T10:34:01.000+02:00
diff --git a/R/echarts4r.R b/R/echarts4r.R
@@ -416,7 +416,7 @@ e_chart <- e_charts
 #'   e_charts_("qsec") |>
 #'   e_line(mpg) |>
 #'   e_data(points, qsec) |>
-#'   e_scatter(mpg, color = "blue")
+#'   e_scatter(mpg, color = "red", symbol_size = 20)
 #' @rdname init
 #' @export
 e_data <- function(e, data, x) {
diff --git a/R/themes.R b/R/themes.R
@@ -42,7 +42,8 @@ e_theme <- function(
     "westeros", "wonderland"
   )
 ) {
-  name <- match.arg(name)
+  # cannot match.arg we need to support custom themes
+  name <- name[1]
 
   # add name to register
   e$x$theme <- name
diff --git a/man/init.Rd b/man/init.Rd

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,8 @@ e_theme <- function(`
`42`	`42`	`"westeros", "wonderland"`
`43`	`43`	`)`
`44`	`44`	`) {`
`45`		`- name <- match.arg(name)`
	`45`	`+ # cannot match.arg we need to support custom themes`
	`46`	`+ name <- name[1]`
`46`	`47`
`47`	`48`	`# add name to register`
`48`	`49`	`e$x$theme <- name`