Don't deref potential null

JohnMcPMS · JohnMcPMS · commit 27143e990f80 · 2025-06-13T15:14:02.000-07:00
diff --git a/src/AppInstallerCLICore/Workflows/PortableFlow.cpp b/src/AppInstallerCLICore/Workflows/PortableFlow.cpp
@@ -111,9 +111,10 @@ namespace AppInstaller::CLI::Workflow
     {
         Manifest::ScopeEnum scope = Manifest::ScopeEnum::Unknown;
         bool isUpdate = WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::InstallerExecutionUseUpdate);
-        if (isUpdate)
+        auto installedVersion = context.Get<Execution::Data::InstalledPackageVersion>();
+        if (isUpdate && installedVersion)
         {
-            IPackageVersion::Metadata installationMetadata = context.Get<Execution::Data::InstalledPackageVersion>()->GetMetadata();
+            IPackageVersion::Metadata installationMetadata = installedVersion->GetMetadata();
             auto installerScopeItr = installationMetadata.find(Repository::PackageVersionMetadata::InstalledScope);
             if (installerScopeItr != installationMetadata.end())
             {

Original file line number	Diff line number	Diff line change
`@@ -111,9 +111,10 @@ namespace AppInstaller::CLI::Workflow`
`111`	`111`	`{`
`112`	`112`	`Manifest::ScopeEnum scope = Manifest::ScopeEnum::Unknown;`
`113`	`113`	`bool isUpdate = WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::InstallerExecutionUseUpdate);`
`114`		`- if (isUpdate)`
	`114`	`+ auto installedVersion = context.Get<Execution::Data::InstalledPackageVersion>();`
	`115`	`+ if (isUpdate && installedVersion)`
`115`	`116`	`{`
`116`		`- IPackageVersion::Metadata installationMetadata = context.Get<Execution::Data::InstalledPackageVersion>()->GetMetadata();`
	`117`	`+ IPackageVersion::Metadata installationMetadata = installedVersion->GetMetadata();`
`117`	`118`	`auto installerScopeItr = installationMetadata.find(Repository::PackageVersionMetadata::InstalledScope);`
`118`	`119`	`if (installerScopeItr != installationMetadata.end())`
`119`	`120`	`{`