Use input handle type to determine if we should attempt to read from it

Author: JohnMcPMS

src/AppInstallerCLICore/Core.cpp

@@ -83,7 +83,7 @@ namespace AppInstaller::CLI
 
         Logging::UseGlobalTelemetryLoggerActivityIdOnly();
 
-        Execution::Context context{ std::cout, std::cin };
+        Execution::Context context;
         auto previousThreadGlobals = context.SetForCurrentThread();
 
         // Set up debug string logging during initialization

src/AppInstallerCLICore/ExecutionContext.h

@@ -93,6 +93,7 @@ namespace AppInstaller::CLI::Execution
     // arguments via Execution::Args.
     struct Context : EnumBasedVariantMap<Data, details::DataMapping, ContextEnumBasedVariantMapActionCallback>
     {
+        Context() = default;
         Context(std::ostream& out, std::istream& in) : Reporter(out, in) {}
 
         // Constructor for creating a sub-context.

src/AppInstallerCLICore/ExecutionReporter.cpp

@@ -23,20 +23,29 @@ namespace AppInstaller::CLI::Execution
     const Sequence& ConfigurationUnitEmphasis = TextFormat::Foreground::BrightCyan;
     const Sequence& AuthenticationEmphasis = TextFormat::Foreground::BrightYellow;
 
-    Reporter::Reporter() :
-        Reporter(std::cout, std::cin)
+    namespace
     {
-        HANDLE outHandle = GetStdHandle(STD_OUTPUT_HANDLE);
-        if (outHandle == INVALID_HANDLE_VALUE)
-        {
-            LOG_LAST_ERROR();
-        }
-        else if (outHandle != NULL)
+        DWORD GetStdHandleType(DWORD stdHandle)
         {
+            DWORD result = FILE_TYPE_UNKNOWN;
+
+            HANDLE handle = GetStdHandle(stdHandle);
+            if (handle != INVALID_HANDLE_VALUE && handle != NULL)
+            {
+                result = GetFileType(handle);
+            }
 
+            return result;
         }
     }
 
+    Reporter::Reporter() :
+        Reporter(std::cout, std::cin)
+    {
+        m_outStreamFileType = GetStdHandleType(STD_OUTPUT_HANDLE);
+        m_inStreamFileType = GetStdHandleType(STD_INPUT_HANDLE);
+    }
+
     Reporter::Reporter(std::ostream& outStream, std::istream& inStream) :
         Reporter(std::make_shared<BaseStream>(outStream, true, ConsoleModeRestore::Instance().IsVTEnabled()), inStream)
     {
@@ -62,6 +71,9 @@ namespace AppInstaller::CLI::Execution
     Reporter::Reporter(const Reporter& other, clone_t) :
         Reporter(other.m_out, other.m_in)
     {
+        m_outStreamFileType = other.m_outStreamFileType;
+        m_inStreamFileType = other.m_inStreamFileType;
+
         SetChannel(other.m_channel);
 
         if (other.m_style.has_value())
@@ -154,7 +166,7 @@ namespace AppInstaller::CLI::Execution
 
     bool Reporter::InputStreamIsInteractive() const
     {
-
+        return m_inStreamFileType == FILE_TYPE_CHAR;
     }
 
     bool Reporter::PromptForBoolResponse(Resource::LocString message, Level level, bool resultIfDisabled)

src/AppInstallerCLICore/ExecutionReporter.h

@@ -208,6 +208,8 @@ namespace AppInstaller::CLI::Execution
         wil::srwlock m_progressCallbackLock;
         std::atomic<ProgressCallback*> m_progressCallback;
         std::atomic<IProgressSink*> m_progressSink;
+        DWORD m_outStreamFileType = FILE_TYPE_UNKNOWN;
+        DWORD m_inStreamFileType = FILE_TYPE_UNKNOWN;
 
         // Enable all levels by default
         Level m_enabledLevels = Level::All;