Skip to content

v10.1.0 release: things to fix before release #401

@JohnXLivingston

Description

@JohnXLivingston

Here is the list of things to fix before releasing v10.1.0:

  • dynamic tables: give the focus to first input when adding a row
  • fix npm run lint so it can handle lit linting errors
    • it appears that lit-analyser, which we use in Codium, has some interesting hightlights. I did not managed to configure it, but it would be great.
    • fix remaining lit linting errors
  • dynamic table: add titles to "+" and "-" buttons
  • dynamic table: add confirmation when deleting a line
  • channel configuration: add a cancel button that reload data from backend
  • channel emojis: add a cancel button
  • in channel-detail, channel-configuration, ... there are some public attributes prefixed by _, and some private attributes without the prefix. Clean that.
  • _asyncTaskRender: handle error (and pending?) case (this method exists in several elements)
  • check that there is no missing localization for error messages (no hard coded labels)
  • dynamic tables: column description on thead title attribute is not very accessible (does not work on mobile, is not easy to find if user don't know it exists)
  • channel configuration: table too large?
  • context in lit elements: seems a bit complicated. Should consider adding a "context provider" elements on each page, that provide various context, so that every other custom elements just have to consume them. Or just some singleton somewhere.
  • .value=${this._channelConfiguration?.configuration.bot.enabled} => should be value="1". This error is present a few times. (not 100% sure of this)
  • save button should be disabled during saving, to show the user something is going on if it takes some times (in channel-configuration and channel-emojis)
  • dynamic table: always have at least an empty line? (i'm not sure of the impact)
  • channel-configuration, channel-emojis, ...: source files are relatively big. Maybe we could separate the "template part" (content of the render method) in separate files. Like in ConverseJS.
  • this._rowsById.filter(rowById => this.rows.includes(rowById.row)) <= seems buggy. Missing assignation of the result?
  • classMap directive: documentation says it must be the only part, but there are some code that mix it with something else.

Metadata

Metadata

Labels

No labels
No labels

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions