Skip to content

Commit c8557b8

Browse files
committed
improved reorder functionality
1 parent 6c03953 commit c8557b8

File tree

5 files changed

+28
-15
lines changed

5 files changed

+28
-15
lines changed

demo/app.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ angular.module('app')
1616
$scope.data.push($scope.createElement());
1717
};
1818

19+
$scope.reorderElements = function () {
20+
$scope.$emit('bricklayer.reorderElements');
21+
};
22+
1923
var sizes = [220, 250, 260, 270, 290, 300, 310, 330, 400, 430, 450, 480, 500];
2024

2125
for (var i = 0; i < 10; i++) {

demo/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@
6262
<iframe src="https://ghbtns.com/github-btn.html?user=JohnnyTheTank&repo=angular-bricklayer&type=star&count=true&size=large" frameborder="0" scrolling="0" width="160px" height="30px"></iframe>
6363

6464
<button ng-click="appendNew()"><strong>Append Item</strong></button>
65+
<button ng-click="reorderElements()"><strong>Reorder Elements</strong></button>
6566

6667
<!-- Bricklayer needs to have "bricklayer" class name. -->
6768
<div class="bricklayer">

dist/angular-bricklayer.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
@name: angular-bricklayer
3-
@version: 1.0.1 (23-04-2016)
3+
@version: 1.0.1 (24-04-2016)
44
@author:
55
@url: https://github.com/JohnnyTheTank/angular-bricklayer
66
@license: MIT
@@ -9,28 +9,34 @@ angular.module('jtt_bricklayer', [])
99
.directive('bricklayer', ['$timeout', function ($timeout) {
1010
return {
1111
restrict: 'C',
12-
replace: 'false',
1312
link: function (scope, element, attrs) {
1413
var bricklayer = new Bricklayer(element[0]);
1514

1615
$timeout(function () {
1716
bricklayer.reorderElements(bricklayer.columnCount);
18-
}, 0);
17+
});
1918

2019
scope.$on('bricklayer.append', function (event, element) {
2120
bricklayer.append(element);
2221
bricklayer.reorderElements(bricklayer.columnCount);
2322
$timeout(function () {
2423
bricklayer.reorderElements(bricklayer.columnCount);
25-
}, 0);
24+
});
2625
});
2726

2827
scope.$on('bricklayer.prepend', function (event, element) {
2928
bricklayer.prepend(element);
3029
bricklayer.reorderElements(bricklayer.columnCount);
3130
$timeout(function () {
3231
bricklayer.reorderElements(bricklayer.columnCount);
33-
}, 0);
32+
});
33+
});
34+
35+
scope.$on('bricklayer.reorderElements', function () {
36+
bricklayer.reorderElements(bricklayer.columnCount);
37+
$timeout(function () {
38+
bricklayer.reorderElements(bricklayer.columnCount);
39+
});
3440
});
3541
}
3642
}
@@ -39,7 +45,6 @@ angular.module('jtt_bricklayer', [])
3945
return {
4046
require: '?bricklayer',
4147
restrict: 'ACE',
42-
replace: 'false',
4348
link: function (scope, element, attrs) {
4449
scope.$emit('bricklayer.append', element[0]);
4550
}
@@ -49,7 +54,6 @@ angular.module('jtt_bricklayer', [])
4954
return {
5055
require: '?bricklayer',
5156
restrict: 'ACE',
52-
replace: 'false',
5357
link: function (scope, element, attrs) {
5458
scope.$emit('bricklayer.prepend', element[0]);
5559
}

dist/angular-bricklayer.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/angular-bricklayer.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,34 @@ angular.module('jtt_bricklayer', [])
22
.directive('bricklayer', ['$timeout', function ($timeout) {
33
return {
44
restrict: 'C',
5-
replace: 'false',
65
link: function (scope, element, attrs) {
76
var bricklayer = new Bricklayer(element[0]);
87

98
$timeout(function () {
109
bricklayer.reorderElements(bricklayer.columnCount);
11-
}, 0);
10+
});
1211

1312
scope.$on('bricklayer.append', function (event, element) {
1413
bricklayer.append(element);
1514
bricklayer.reorderElements(bricklayer.columnCount);
1615
$timeout(function () {
1716
bricklayer.reorderElements(bricklayer.columnCount);
18-
}, 0);
17+
});
1918
});
2019

2120
scope.$on('bricklayer.prepend', function (event, element) {
2221
bricklayer.prepend(element);
2322
bricklayer.reorderElements(bricklayer.columnCount);
2423
$timeout(function () {
2524
bricklayer.reorderElements(bricklayer.columnCount);
26-
}, 0);
25+
});
26+
});
27+
28+
scope.$on('bricklayer.reorderElements', function () {
29+
bricklayer.reorderElements(bricklayer.columnCount);
30+
$timeout(function () {
31+
bricklayer.reorderElements(bricklayer.columnCount);
32+
});
2733
});
2834
}
2935
}
@@ -32,7 +38,6 @@ angular.module('jtt_bricklayer', [])
3238
return {
3339
require: '?bricklayer',
3440
restrict: 'ACE',
35-
replace: 'false',
3641
link: function (scope, element, attrs) {
3742
scope.$emit('bricklayer.append', element[0]);
3843
}
@@ -42,7 +47,6 @@ angular.module('jtt_bricklayer', [])
4247
return {
4348
require: '?bricklayer',
4449
restrict: 'ACE',
45-
replace: 'false',
4650
link: function (scope, element, attrs) {
4751
scope.$emit('bricklayer.prepend', element[0]);
4852
}

0 commit comments

Comments
 (0)