chore: replace .success() and .error() with .then() and .catch() (#1)

Author: JohnnyTheTank

README.md

@@ -25,9 +25,9 @@ Author: Jonathan Hornung ([JohnnyTheTank](https://github.com/JohnnyTheTank))
 githubFactory.getUser({
     user:"<USERNAME_NAME>",
     access_token:"<ACCESS_TOKEN>"
-}).success(function(_data){
+}).then(function(_data){
     //on success
-}).error(function (_data) {
+}).catch(function (_data) {
     //on error
 });
 ```
@@ -38,9 +38,9 @@ githubFactory.getRepoByUserAndName({
     user:"<USER_NAME>",
     repo:"<REPO_NAME>",
     access_token:"<ACCESS_TOKEN>"
-}).success(function(_data){
+}).then(function(_data){
     //on success
-}).error(function (_data) {
+}).catch(function (_data) {
     //on error
 });
 ```
@@ -54,9 +54,9 @@ githubFactory.getReposByName({
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
     access_token:"<ACCESS_TOKEN>"
-}).success(function(_data){
+}).then(function(_data){
     //on success
-}).error(function (_data) {
+}).catch(function (_data) {
     //on error
 });
 ```
@@ -69,9 +69,9 @@ githubFactory.getReposByUser({
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
     access_token:"<ACCESS_TOKEN>"
-}).success(function(_data){
+}).then(function(_data){
     //on success
-}).error(function (_data) {
+}).catch(function (_data) {
     //on error
 });
 ```
@@ -86,9 +86,9 @@ githubFactory.getEventsFromRepoByUserAndName({
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
     access_token:"<ACCESS_TOKEN>"
-}).success(function(_data){
+}).then(function(_data){
     //on success
-}).error(function (_data) {
+}).catch(function (_data) {
     //on error
 });
 ```
@@ -101,9 +101,9 @@ githubFactory.getEventsByUser({
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
     access_token:"<ACCESS_TOKEN>"
-}).success(function(_data){
+}).then(function(_data){
     //on success
-}).error(function (_data) {
+}).catch(function (_data) {
     //on error
 });
 ```

bower.json

@@ -1,8 +1,8 @@
 {
   "name": "angular-github-api-factory",
   "description": "angularjs factory for github json rest api requests",
-  "version": "0.1.2",
-  "main": "Gruntfile.js",
+  "version": "0.5.0",
+  "main": "dist/angular-github-api-factory.js",
   "authors": [
     "Jonathan Hornung"
   ],

demo/js/app.js

@@ -6,7 +6,7 @@ app.controller('controller', ['$scope', 'githubFactory', function($scope, github
     githubFactory.getUser({
         user:"xremix",
         access_token:_access_token
-    }).success(function(_data){
+    }).then(function(_data){
         console.info("user", _data);
     });
 
@@ -22,15 +22,15 @@ app.controller('controller', ['$scope', 'githubFactory', function($scope, github
         q:"apiNG-plugin",
         per_page: 20,
         access_token:_access_token
-    }).success(function(_data){
+    }).then(function(_data){
         console.info("repos by name", _data);
     });
 
     githubFactory.getEventsByUser({
         user:"xremix",
         per_page: 20,
         access_token:_access_token
-    }).success(function(_data){
+    }).then(function(_data){
         console.info("events by user", _data);
     });
 
@@ -39,7 +39,7 @@ app.controller('controller', ['$scope', 'githubFactory', function($scope, github
         repo:"apiNG",
         per_page: 100,
         access_token:_access_token
-    }).success(function(_data){
+    }).then(function(_data){
         console.info("events from repo by user and name", _data);
     });
 
@@ -48,7 +48,7 @@ app.controller('controller', ['$scope', 'githubFactory', function($scope, github
         repo:"xGallerify",
         per_page: 20,
         access_token:_access_token
-    }).success(function(_data){
+    }).then(function(_data){
         console.info("repo by user and name", _data);
     });
 

package.json

@@ -1,8 +1,8 @@
 {
   "name": "angular-github-api-factory",
-  "version": "0.1.2",
+  "version": "0.5.2",
   "description": "angularjs factory for github json rest api requests",
-  "main": "Gruntfile.js",
+  "main": "dist/angular-github-api-factory.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
   },
@@ -23,6 +23,9 @@
     "url": "https://github.com/JohnnyTheTank/angular-github-api-factory/issues"
   },
   "homepage": "https://github.com/JohnnyTheTank/angular-github-api-factory#readme",
+  "dependencies": {
+    "angular": "*"
+  },
   "devDependencies": {
     "grunt": "^0.4.5",
     "grunt-contrib-uglify": "^0.11.0",