New unit tests

Author: wmathurin

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SFUserAccountManagerTests.m

@@ -664,4 +664,96 @@ - (void)testUserAccountEncoding {
     XCTAssertEqual(userIn.accessRestrictions, userOut.accessRestrictions, @"accessRestrictions mismatch");
 }
 
+#pragma mark - authRequestWithLoginHost Tests
+
+- (void)testAuthRequestWithLoginHostDefaults {
+    // Setup default values
+    NSString *expectedLoginHost = @"https://login.salesforce.com";
+    NSString *expectedClientId = @"testClientId";
+    NSString *expectedRedirectUri = @"testapp://oauth/done";
+    NSSet *expectedScopes = [NSSet setWithObjects:@"api", @"web", @"refresh_token", nil];
+    
+    self.uam.loginHost = expectedLoginHost;
+    self.uam.oauthClientId = expectedClientId;
+    self.uam.oauthCompletionUrl = expectedRedirectUri;
+    self.uam.scopes = expectedScopes;
+    
+    // Call with nil loginHost and nil appConfig (should use defaults)
+    SFSDKAuthRequest *request = [self.uam authRequestWithLoginHost:nil appConfig:nil];
+    
+    XCTAssertNotNil(request, @"Auth request should not be nil");
+    XCTAssertEqualObjects(request.loginHost, expectedLoginHost, @"Login host should match default");
+    XCTAssertEqualObjects(request.oauthClientId, expectedClientId, @"Client ID should match default");
+    XCTAssertEqualObjects(request.oauthCompletionUrl, expectedRedirectUri, @"Redirect URI should match default");
+    XCTAssertEqualObjects(request.scopes, expectedScopes, @"Scopes should match default");
+}
+
+- (void)testAuthRequestWithLoginHostCustomHost {
+    // Setup default values
+    NSString *defaultLoginHost = @"https://login.salesforce.com";
+    NSString *customLoginHost = @"https://test.salesforce.com";
+    NSString *expectedClientId = @"testClientId";
+    
+    self.uam.loginHost = defaultLoginHost;
+    self.uam.oauthClientId = expectedClientId;
+    
+    // Call with custom loginHost
+    SFSDKAuthRequest *request = [self.uam authRequestWithLoginHost:customLoginHost appConfig:nil];
+    
+    XCTAssertNotNil(request, @"Auth request should not be nil");
+    XCTAssertEqualObjects(request.loginHost, customLoginHost, @"Login host should be custom value, not default");
+    XCTAssertEqualObjects(request.oauthClientId, expectedClientId, @"Client ID should match default");
+}
+
+- (void)testAuthRequestWithLoginHostWithAppConfig {
+    // Setup default values
+    NSString *defaultLoginHost = @"https://login.salesforce.com";
+    NSString *defaultClientId = @"defaultClientId";
+    NSString *defaultRedirectUri = @"defaultapp://oauth/done";
+    NSSet *defaultScopes = [NSSet setWithObjects:@"api", @"web", nil];
+    
+    self.uam.loginHost = defaultLoginHost;
+    self.uam.oauthClientId = defaultClientId;
+    self.uam.oauthCompletionUrl = defaultRedirectUri;
+    self.uam.scopes = defaultScopes;
+    
+    // Create app config with different values
+    NSString *appConfigClientId = @"appConfigClientId";
+    NSString *appConfigRedirectUri = @"appconfig://oauth/done";
+    NSSet *appConfigScopes = [NSSet setWithObjects:@"id", @"api", @"refresh_token", nil];
+    
+    NSDictionary *configDict = @{
+        @"remoteAccessConsumerKey": appConfigClientId,
+        @"oauthRedirectURI": appConfigRedirectUri,
+        @"oauthScopes": [appConfigScopes allObjects],
+        @"shouldAuthenticate": @YES
+    };
+    SFSDKAppConfig *appConfig = [[SFSDKAppConfig alloc] initWithDict:configDict];
+    
+    // Call with appConfig
+    SFSDKAuthRequest *request = [self.uam authRequestWithLoginHost:nil appConfig:appConfig];
+    
+    XCTAssertNotNil(request, @"Auth request should not be nil");
+    XCTAssertEqualObjects(request.loginHost, defaultLoginHost, @"Login host should match default");
+    XCTAssertEqualObjects(request.oauthClientId, appConfigClientId, @"Client ID should come from appConfig");
+    XCTAssertEqualObjects(request.oauthCompletionUrl, appConfigRedirectUri, @"Redirect URI should come from appConfig");
+    XCTAssertEqualObjects(request.scopes, appConfigScopes, @"Scopes should come from appConfig");
+}
+
+- (void)testDefaultAuthRequestUsesAuthRequestWithLoginHost {
+    // Setup default values
+    NSString *expectedLoginHost = @"https://login.salesforce.com";
+    NSString *expectedClientId = @"testClientId";
+    
+    self.uam.loginHost = expectedLoginHost;
+    self.uam.oauthClientId = expectedClientId;
+    
+    // defaultAuthRequest should call authRequestWithLoginHost:nil appConfig:nil
+    SFSDKAuthRequest *request = [self.uam defaultAuthRequest];
+    
+    XCTAssertNotNil(request, @"Default auth request should not be nil");
+    XCTAssertEqualObjects(request.loginHost, expectedLoginHost, @"Login host should match default");
+    XCTAssertEqualObjects(request.oauthClientId, expectedClientId, @"Client ID should match default");
+}
+
 @end

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SalesforceSDKManagerTests.m

@@ -485,4 +485,76 @@ - (void)compareAppNames:(NSString *)expectedAppName
     XCTAssertTrue([userAgent containsString:expectedAppName], @"App names should match");
 }
 
+#pragma mark - Runtime Selected App Config Tests
+
+- (void)testRuntimeSelectedAppConfigReturnsNilWhenBlockNotSet {
+    // Clear any existing block
+    [SalesforceSDKManager sharedManager].appConfigRuntimeSelectorBlock = nil;
+    
+    // Call with nil loginHost
+    SFSDKAppConfig *config = [[SalesforceSDKManager sharedManager] runtimeSelectedAppConfig:nil];
+    XCTAssertNil(config, @"Should return nil when no selector block is set");
+    
+    // Call with a loginHost
+    config = [[SalesforceSDKManager sharedManager] runtimeSelectedAppConfig:@"https://test.salesforce.com"];
+    XCTAssertNil(config, @"Should return nil when no selector block is set, regardless of loginHost");
+}
+
+- (void)testRuntimeSelectedAppConfigWithDifferentLoginHosts {
+    NSString *loginHost1 = @"https://login.salesforce.com";
+    NSString *loginHost2 = @"https://test.salesforce.com";
+    
+    NSDictionary *config1Dict = @{
+        @"remoteAccessConsumerKey": @"clientId1",
+        @"oauthRedirectURI": @"app1://oauth/done",
+        @"shouldAuthenticate": @YES
+    };
+    SFSDKAppConfig *config1 = [[SFSDKAppConfig alloc] initWithDict:config1Dict];
+    
+    NSDictionary *config2Dict = @{
+        @"remoteAccessConsumerKey": @"clientId2",
+        @"oauthRedirectURI": @"app2://oauth/done",
+        @"shouldAuthenticate": @YES
+    };
+    SFSDKAppConfig *config2 = [[SFSDKAppConfig alloc] initWithDict:config2Dict];
+    
+    // Set the selector block to return different configs based on loginHost
+    [SalesforceSDKManager sharedManager].appConfigRuntimeSelectorBlock = ^SFSDKAppConfig *(NSString *loginHost) {
+        if ([loginHost isEqualToString:loginHost1]) {
+            return config1;
+        } else if ([loginHost isEqualToString:loginHost2]) {
+            return config2;
+        }
+        return nil;
+    };
+    
+    // Test first loginHost
+    SFSDKAppConfig *result1 = [[SalesforceSDKManager sharedManager] runtimeSelectedAppConfig:loginHost1];
+    XCTAssertNotNil(result1, @"Should return config for loginHost1");
+    XCTAssertEqual(result1, config1, @"Should return config1 for loginHost1");
+    XCTAssertEqualObjects(result1.remoteAccessConsumerKey, @"clientId1", @"Should have correct client ID for config1");
+    
+    // Test second loginHost
+    SFSDKAppConfig *result2 = [[SalesforceSDKManager sharedManager] runtimeSelectedAppConfig:loginHost2];
+    XCTAssertNotNil(result2, @"Should return config for loginHost2");
+    XCTAssertEqual(result2, config2, @"Should return config2 for loginHost2");
+    XCTAssertEqualObjects(result2.remoteAccessConsumerKey, @"clientId2", @"Should have correct client ID for config2");
+}
+
+- (void)testRuntimeSelectedAppConfigBlockReturnsNil {
+    __block BOOL blockWasCalled = NO;
+    
+    // Set the selector block to return nil
+    [SalesforceSDKManager sharedManager].appConfigRuntimeSelectorBlock = ^SFSDKAppConfig *(NSString *loginHost) {
+        blockWasCalled = YES;
+        return nil;
+    };
+    
+    // Call the method
+    SFSDKAppConfig *config = [[SalesforceSDKManager sharedManager] runtimeSelectedAppConfig:@"https://test.salesforce.com"];
+    
+    XCTAssertTrue(blockWasCalled, @"Block should have been called");
+    XCTAssertNil(config, @"Should return nil when block returns nil");
+}
+
 @end