Add test

Author: bbirman

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/OAuth/DomainDiscoveryCoordinator.swift

@@ -78,7 +78,13 @@ public class DomainDiscoveryCoordinator: NSObject {
     }
 
     @objc
+    @available(*, deprecated, renamed: "isDiscoveryDomain(domain:)")
     public func isDiscoveryDomain(_ domain: String?, clientId: String?) -> Bool {
+       return isDiscoveryDomain(domain)
+    }
+    
+    @objc
+    public func isDiscoveryDomain(_ domain: String?) -> Bool {
         guard let domain = domain else { return false }
         let isDiscovery = domain.lowercased().contains(DomainDiscovery.URLComponent.path.rawValue)
         let discoveryEnabled = SalesforceManager.shared.useWelcomeDiscovery

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m

@@ -49,6 +49,7 @@
 #import "SFSDKIDPConstants.h"
 #import "SFSDKAuthSession.h"
 #import "SFSDKAuthRequest.h"
+#import <SalesforceSDKCore/SalesforceSDKCore-Swift.h>
 #import <SalesforceSDKCommon/SalesforceSDKCommon-Swift.h>
 #import <SalesforceSDKCommon/SFSDKDatasharingHelper.h>
 #import <LocalAuthentication/LocalAuthentication.h>
@@ -213,8 +214,7 @@ - (void)authenticate {
 
 - (void)authenticateWithCredentials:(SFOAuthCredentials *)credentials {
     self.credentials = credentials;
-    if ([self.domainDiscoveryCoordinator isDiscoveryDomain:self.credentials.domain
-                                                 clientId:self.credentials.clientId]) {
+    if ([self.domainDiscoveryCoordinator isDiscoveryDomain:self.credentials.domain]) {
         [self runMyDomainDiscoveryAndAuthenticate];
         return;
     }

libs/SalesforceSDKCore/SalesforceSDKCoreTests/DomainDiscoveryCoordinatorTests.swift

@@ -155,4 +155,15 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
         XCTAssertEqual(results?.myDomain, expectedDomain)
         XCTAssertEqual(results?.loginHint, expectedLoginHint)
     }
-} 
+    
+    func testDiscoveryFlag() throws {
+        let coordinator = DomainDiscoveryCoordinator()
+        let domain = "welcome.salesforce.com/discovery"
+        
+        SalesforceManager.shared.useWelcomeDiscovery = false
+        XCTAssertFalse(coordinator.isDiscoveryDomain(domain))
+        
+        SalesforceManager.shared.useWelcomeDiscovery = true
+        XCTAssertTrue(coordinator.isDiscoveryDomain(domain)) 
+    }
+}