Merge pull request mautic#15255 from andersonjeccel/forms-disable-search-indexing-by-default

Forms: Set "Disable search indexing" as enabled by default

Author: escopecz

app/bundles/FormBundle/Entity/Form.php

@@ -165,6 +165,7 @@ public function __construct()
         $this->fields      = new ArrayCollection();
         $this->actions     = new ArrayCollection();
         $this->submissions = new ArrayCollection();
+        $this->noIndex     = true;
         $this->initializeProjects();
     }
 

app/bundles/FormBundle/Form/Type/FormType.php

@@ -136,7 +136,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             YesNoButtonGroupType::class,
             [
                 'label' => 'mautic.form.form.no_index',
-                'data'  => $options['data']->getNoIndex() ?: false,
+                'data'  => $options['data']->getNoIndex(),
             ]
         );
 

app/bundles/FormBundle/Tests/Entity/FormTest.php

@@ -22,12 +22,12 @@ public function testSetNoIndex($value, $expected, array $changes): void
 
     public static function setNoIndexDataProvider(): iterable
     {
-        yield [null, null, []];
-        yield [true, true, ['noIndex' => [null, true]]];
-        yield [false, false, ['noIndex' => [null, false]]];
-        yield ['', false, ['noIndex' => [null, false]]];
-        yield [0, false, ['noIndex' => [null, false]]];
-        yield ['string', true, ['noIndex' => [null, true]]];
+        yield [null, null, ['noIndex' => [true, null]]];
+        yield [true, true, []];
+        yield [false, false, ['noIndex' => [true, false]]];
+        yield ['', false, ['noIndex' => [true, false]]];
+        yield [0, false, ['noIndex' => [true, false]]];
+        yield ['string', true, []];
     }
 
     public function testGetMappedFieldValues(): void