Merge pull request #19 from mhutter/fix/cache

JonasProgrammer · web-flow · commit 5de469aca7d6 · 2018-10-23T12:03:07.000+02:00
Cache server in success case, not error case
diff --git a/driver.go b/driver.go
@@ -522,9 +522,10 @@ func (d *Driver) getServerHandle() (*hcloud.Server, error) {
 
 	srv, _, err := d.getClient().Server.GetByID(context.Background(), d.ServerID)
 	if err != nil {
-		d.cachedServer = srv
 		return nil, errors.Wrap(err, "could not get client by ID")
 	}
+
+	d.cachedServer = srv
 	return srv, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -522,9 +522,10 @@ func (d Driver) getServerHandle() (hcloud.Server, error) {`
`522`	`522`
`523`	`523`	`srv, _, err := d.getClient().Server.GetByID(context.Background(), d.ServerID)`
`524`	`524`	`if err != nil {`
`525`		`- d.cachedServer = srv`
`526`	`525`	`return nil, errors.Wrap(err, "could not get client by ID")`
`527`	`526`	`}`
	`527`	`+`
	`528`	`+ d.cachedServer = srv`
`528`	`529`	`return srv, nil`
`529`	`530`	`}`
`530`	`531`