Refactor useFolderTree and bookmarkFactory to use BookmarkTreeNode for improved type safety

Author: JonathanPiaget

src/composables/useFolderTree.ts

@@ -1,12 +1,7 @@
 import { ref } from 'vue';
+import type { Browser } from 'wxt/browser';
 
-export interface BookmarkNode {
-	id: string;
-	title: string;
-	url?: string;
-	parentId?: string;
-	children?: BookmarkNode[];
-}
+type BookmarkTreeNode = Browser.bookmarks.BookmarkTreeNode;
 
 export interface BookmarkFolder {
 	id: string;
@@ -21,7 +16,7 @@ export function useFolderTree() {
 	const folderMap = ref<Map<string, BookmarkFolder>>(new Map());
 
 	const buildFolderTree = (
-		nodes: BookmarkNode[],
+		nodes: BookmarkTreeNode[],
 		parentPath = '',
 		level = 0,
 	): BookmarkFolder[] => {
@@ -62,7 +57,7 @@ export function useFolderTree() {
 	const loadFolders = async () => {
 		try {
 			const tree = await browser.bookmarks.getTree();
-			const folders = buildFolderTree(tree as BookmarkNode[]);
+			const folders = buildFolderTree(tree);
 
 			allFolders.value = folders.filter(
 				(folder) => folder.title !== '' && folder.id !== '0',

src/test-utils/bookmarkFactory.ts

@@ -1,7 +1,7 @@
-import type {
-	BookmarkFolder,
-	BookmarkNode,
-} from '../composables/useFolderTree';
+import type { Browser } from 'wxt/browser';
+import type { BookmarkFolder } from '../composables/useFolderTree';
+
+type BookmarkTreeNode = Browser.bookmarks.BookmarkTreeNode;
 
 /**
  * Factory for creating realistic bookmark test data
@@ -21,7 +21,7 @@ export interface CreateNodeOptions {
 	title: string;
 	url?: string;
 	parentId?: string;
-	children?: BookmarkNode[];
+	children?: BookmarkTreeNode[];
 }
 
 /**
@@ -38,12 +38,13 @@ export function createFolder(options: CreateFolderOptions): BookmarkFolder {
 }
 
 /**
- * Creates a single BookmarkNode (raw browser format)
+ * Creates a single BookmarkTreeNode (raw browser format)
  */
-export function createNode(options: CreateNodeOptions): BookmarkNode {
+export function createNode(options: CreateNodeOptions): BookmarkTreeNode {
 	return {
 		id: options.id || `node-${Math.random().toString(36).substr(2, 9)}`,
 		title: options.title,
+		syncing: false, // Default to not synced for test data
 		url: options.url,
 		parentId: options.parentId,
 		children: options.children,