Replies: 7 comments
-
|
Great idea, Eugen. I originally modeled the Scripture entry on SermonCentral.com. |
Beta Was this translation helpful? Give feedback.
-
|
We still cold us the tables as is but just do some JS to fill in the right On Tue, Apr 9, 2013 at 9:52 AM, tomfuller2 notifications@github.com wrote:
Thanks, |
Beta Was this translation helpful? Give feedback.
-
|
@bcordis The filters by default, I believe, work only on column values, so for filtering by a specific book under this method is a little bit more complex. If we implement this in a utility class (or library?), then the burden would be on this utility class of providing proper methods for handling filtering, localization, and other required functionality. |
Beta Was this translation helpful? Give feedback.
-
|
@genu |
Beta Was this translation helpful? Give feedback.
-
|
I didn't look how the contacts component works. We could, as a first step in this direction, take that route and just map a string of scripture references to those table columns. However, we will still be limited by only 2 scripture references per message. correct? |
Beta Was this translation helpful? Give feedback.
-
|
unless we redo the db and do it in a JSON string in one column. On Tue, Apr 9, 2013 at 11:06 AM, Eugen Istoc notifications@github.comwrote:
Thanks, |
Beta Was this translation helpful? Give feedback.
-
|
This has been fully implemented in PR #1056 (merged into What was built:
This addresses the original request from 2013 — scripture entry is now a single text field with autocomplete, unlimited references, and proper validation. The old 10-column approach is fully replaced. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
For the longest time, the scripture has been inputed as: book, chapter_begin, verse_begin, verse_end, chapter_end, book2, chapter_begin2 etc.
A good improvement to this, is to allow the user to enter scripture references directly like so:
John 3:16, Romans 1:16I'm thinking this could be implemented as a single text field with autocomplete, so that only correct scripture references are acceptable.
A utility class will need to be created to validate a given input to test whether its a valid scripture or not. (i.e.
John 3:16would be valid, whilejohn 0:16would be invalid). The user is alerted whether a references they entered is valid or not as they're entering it. Multiple references are simply separated by a comma.Taking this approach, will allow us to truncate more than 10 columns in the message database.
Related Tasks
Beta Was this translation helpful? Give feedback.
All reactions