feat: improve notification UX and PM2 error handling

Author: KristjanESPERANTO

node_helper.js

@@ -1022,37 +1022,53 @@ module.exports = NodeHelper.create({
   },
 
   controlPm2 (res, query) {
-    try { require("pm2"); } catch (err) {
-      this.sendResponse(res, err, {reason: "PM2 not installed or unlinked"});
+    const actionName = query.action.toLowerCase();
+
+    // Check if PM2 is available
+    try {
+      require.resolve("pm2");
+    } catch {
+      // PM2 not installed
+      const message = `MagicMirror² is not running under PM2. Please ${actionName} manually.`;
+      Log.log(`[MMM-Remote-Control] ${message}`);
+      this.sendResponse(res, undefined, {action: actionName, info: message, status: "info"});
       return;
     }
+
     const pm2 = require("pm2");
     const processName = query.processName || this.thisConfig.pm2ProcessName || "mm";
 
     pm2.connect((err) => {
       if (err) {
-        this.sendResponse(res, err);
+        pm2.disconnect();
+        const message = `MagicMirror² is not running under PM2. Please ${actionName} manually.`;
+        Log.log(`[MMM-Remote-Control] ${message}`);
+        this.sendResponse(res, undefined, {action: actionName, info: message, status: "info"});
         return;
       }
 
-      const actionName = query.action.toLowerCase();
-      Log.log(`[MMM-Remote-Control] PM2 process: ${actionName} ${processName}`);
+      // Check if process is running in PM2
+      pm2.list((err, list) => {
+        if (err || !list.find((proc) => proc.name === processName && proc.pm2_env.status === "online")) {
+          pm2.disconnect();
+          const message = `MagicMirror² is not running under PM2. Please ${actionName} manually.`;
+          Log.log(`[MMM-Remote-Control] ${message}`);
+          this.sendResponse(res, undefined, {action: actionName, info: message, status: "info"});
+          return;
+        }
 
-      switch (actionName) {
-        case "restart":
-          pm2.restart(processName, (err) => {
-            this.sendResponse(res, undefined, {action: actionName, processName});
-            if (err) { this.sendResponse(res, err); }
-          });
-          break;
-        case "stop":
-          pm2.stop(processName, (err) => {
+        // Process is running in PM2, perform action
+        pm2[actionName](processName, (err) => {
+          pm2.disconnect();
+          if (err) {
+            Log.error(`[MMM-Remote-Control] PM2 ${actionName} error:`, err);
+            this.sendResponse(res, err);
+          } else {
+            Log.log(`[MMM-Remote-Control] PM2 ${actionName}: ${processName}`);
             this.sendResponse(res, undefined, {action: actionName, processName});
-            pm2.disconnect();
-            if (err) { this.sendResponse(res, err); }
-          });
-          break;
-      }
+          }
+        });
+      });
     });
   },
 

remote.js

@@ -29,8 +29,10 @@ const Remote = {
   addModule: "",
   changedModules: [],
   deletedModules: [],
-  autoHideTimer: undefined,
-  autoHideDelay: 1000, // ms
+  autoHideTimer: undefined, // Internal: Reference to the active auto-hide timeout (do not modify manually)
+  autoHideDelay: 2000, // ms - Time after which success messages are auto hidden
+  autoHideDelayError: 30 * 1000, // ms - Time for error messages (0 = no auto-hide, must be clicked away)
+  autoHideDelayInfo: 30 * 1000, // ms - Time for info messages like PM2 restart/stop
 
   /*
    * socket()
@@ -408,7 +410,28 @@ const Remote = {
     if (status === "error") {
       symbol = "fa-exclamation-circle";
       text = this.translate("ERROR");
-      onClick = false;
+      onClick = function () {
+        self.setStatus("none");
+      };
+      // Only auto-hide errors if autoHideDelayError > 0, otherwise user must click to dismiss
+      if (this.autoHideDelayError > 0) {
+        this.autoHideTimer = setTimeout(() => {
+          self.setStatus("none");
+        }, this.autoHideDelayError);
+      }
+    }
+    if (status === "info") {
+      symbol = "fa-info-circle";
+      text = this.translate("INFO");
+      onClick = function () {
+        self.setStatus("none");
+      };
+      // Info messages (like PM2 restart/stop) should be displayed longer
+      if (this.autoHideDelayInfo > 0) {
+        this.autoHideTimer = setTimeout(() => {
+          self.setStatus("none");
+        }, this.autoHideDelayInfo);
+      }
     }
     if (status === "success") {
       symbol = "fa-check-circle";

translations/de.json

@@ -60,6 +60,7 @@
 
   "DONE": "Fertig.",
   "ERROR": "Fehler!",
+  "INFO": "Info",
   "LOADING": "Lade …",
 
   "LOCKSTRING_WARNING": "Dieses Modul wurde durch LIST_OF_MODULES versteckt, es kann nicht angezeigt werden.",

translations/en.json

@@ -60,6 +60,7 @@
 
   "DONE": "Done.",
   "ERROR": "Error!",
+  "INFO": "Info",
   "LOADING": "Loading …",
 
   "LOCKSTRING_WARNING": "This module was hidden by LIST_OF_MODULES, it can not be shown.",