Skip to content

Commit 07ae927

Browse files
geertualexandrebelloni
authored andcommitted
rtc: mpfs: Remove printing of stray CR
During boot, the driver prints out a stray carriage return character. Remove it, together with the preceding space character. While at it, change prescaler to "unsigned long", as returned by clk_get_rate(), to avoid truncating very large clock rates, and update the format specifiers. Fixes: 0b31d70 ("rtc: Add driver for Microchip PolarFire SoC") Signed-off-by: Geert Uytterhoeven <[email protected]> Reviewed-by: Conor Dooley <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]> Link: https://lore.kernel.org/r/bce2ca405ef96b1363fd1370887409d9e8468422.1660659437.git.geert+renesas@glider.be
1 parent 568035b commit 07ae927

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/rtc/rtc-mpfs.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static int mpfs_rtc_probe(struct platform_device *pdev)
233233
{
234234
struct mpfs_rtc_dev *rtcdev;
235235
struct clk *clk;
236-
u32 prescaler;
236+
unsigned long prescaler;
237237
int wakeup_irq, ret;
238238

239239
rtcdev = devm_kzalloc(&pdev->dev, sizeof(struct mpfs_rtc_dev), GFP_KERNEL);
@@ -275,14 +275,13 @@ static int mpfs_rtc_probe(struct platform_device *pdev)
275275

276276
/* prescaler hardware adds 1 to reg value */
277277
prescaler = clk_get_rate(devm_clk_get(&pdev->dev, "rtcref")) - 1;
278-
279278
if (prescaler > MAX_PRESCALER_COUNT) {
280-
dev_dbg(&pdev->dev, "invalid prescaler %d\n", prescaler);
279+
dev_dbg(&pdev->dev, "invalid prescaler %lu\n", prescaler);
281280
return -EINVAL;
282281
}
283282

284283
writel(prescaler, rtcdev->base + PRESCALER_REG);
285-
dev_info(&pdev->dev, "prescaler set to: 0x%X \r\n", prescaler);
284+
dev_info(&pdev->dev, "prescaler set to: %lu\n", prescaler);
286285

287286
device_init_wakeup(&pdev->dev, true);
288287
ret = dev_pm_set_wake_irq(&pdev->dev, wakeup_irq);

0 commit comments

Comments
 (0)