Skip to content

Commit 0e6c027

Browse files
smaeulMarc Zyngier
authored andcommitted
genirq: GENERIC_IRQ_EFFECTIVE_AFF_MASK depends on SMP
An IRQ's effective affinity can only be different from its configured affinity if there are multiple CPUs. Make it clear that this option is only meaningful when SMP is enabled. Most of the relevant code in irqdesc.c is already hidden behind CONFIG_SMP anyway. Signed-off-by: Samuel Holland <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 0f5209f commit 0e6c027

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

arch/arm/mach-hisi/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ config ARCH_HIP04
4040
select HAVE_ARM_ARCH_TIMER
4141
select MCPM if SMP
4242
select MCPM_QUAD_CLUSTER if SMP
43-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
43+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
4444
help
4545
Support for Hisilicon HiP04 SoC family
4646

drivers/irqchip/Kconfig

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ config IRQCHIP
88
config ARM_GIC
99
bool
1010
select IRQ_DOMAIN_HIERARCHY
11-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
11+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
1212

1313
config ARM_GIC_PM
1414
bool
@@ -34,7 +34,7 @@ config ARM_GIC_V3
3434
bool
3535
select IRQ_DOMAIN_HIERARCHY
3636
select PARTITION_PERCPU
37-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
37+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
3838

3939
config ARM_GIC_V3_ITS
4040
bool
@@ -76,7 +76,7 @@ config ARMADA_370_XP_IRQ
7676
bool
7777
select GENERIC_IRQ_CHIP
7878
select PCI_MSI if PCI
79-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
79+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
8080

8181
config ALPINE_MSI
8282
bool
@@ -112,15 +112,15 @@ config BCM6345_L1_IRQ
112112
bool
113113
select GENERIC_IRQ_CHIP
114114
select IRQ_DOMAIN
115-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
115+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
116116

117117
config BCM7038_L1_IRQ
118118
tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver"
119119
depends on ARCH_BRCMSTB || BMIPS_GENERIC
120120
default ARCH_BRCMSTB || BMIPS_GENERIC
121121
select GENERIC_IRQ_CHIP
122122
select IRQ_DOMAIN
123-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
123+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
124124

125125
config BCM7120_L2_IRQ
126126
tristate "Broadcom STB 7120-style L2 interrupt controller driver"
@@ -179,7 +179,7 @@ config IRQ_MIPS_CPU
179179
select GENERIC_IRQ_CHIP
180180
select GENERIC_IRQ_IPI if SMP && SYS_SUPPORTS_MULTITHREADING
181181
select IRQ_DOMAIN
182-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
182+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
183183

184184
config CLPS711X_IRQCHIP
185185
bool
@@ -294,7 +294,7 @@ config VERSATILE_FPGA_IRQ_NR
294294
config XTENSA_MX
295295
bool
296296
select IRQ_DOMAIN
297-
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
297+
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
298298

299299
config XILINX_INTC
300300
bool "Xilinx Interrupt Controller IP"

kernel/irq/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ config GENERIC_IRQ_SHOW_LEVEL
2424

2525
# Supports effective affinity mask
2626
config GENERIC_IRQ_EFFECTIVE_AFF_MASK
27+
depends on SMP
2728
bool
2829

2930
# Support for delayed migration from interrupt context

0 commit comments

Comments
 (0)