Skip to content

Commit 3026b5c

Browse files
Dan Carpentermripard
authored andcommitted
drm/vc4: fix error code in vc4_check_tex_size()
The vc4_check_tex_size() function is supposed to return false on error but this error path accidentally returns -ENODEV (which means true). Fixes: 30f8c74 ("drm/vc4: Warn if some v3d code is run on BCM2711") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Maxime Ripard <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/YrMKK89/viQiaiAg@kili
1 parent f5aa168 commit 3026b5c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/vc4/vc4_validate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ vc4_check_tex_size(struct vc4_exec_info *exec, struct drm_gem_cma_object *fbo,
170170
uint32_t utile_h = utile_height(cpp);
171171

172172
if (WARN_ON_ONCE(vc4->is_vc5))
173-
return -ENODEV;
173+
return false;
174174

175175
/* The shaded vertex format stores signed 12.4 fixed point
176176
* (-2048,2047) offsets from the viewport center, so we should

0 commit comments

Comments
 (0)