Skip to content

Commit 415ba26

Browse files
Heikki Krogerusgregkh
authored andcommitted
usb: typec: ucsi: Remove incorrect warning
Sink only devices do not have any source capabilities, so the driver should not warn about that. Also DRP (Dual Role Power) capable devices, such as USB Type-C docking stations, do not return any source capabilities unless they are plugged to a power supply themselves. Fixes: 1f4642b ("usb: typec: ucsi: Retrieve all the PDOs instead of just the first 4") Reported-by: Paul Menzel <[email protected]> Cc: <[email protected]> Signed-off-by: Heikki Krogerus <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent f208ce4 commit 415ba26

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/usb/typec/ucsi/ucsi.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -588,8 +588,6 @@ static int ucsi_get_pdos(struct ucsi_connector *con, int is_partner,
588588
num_pdos * sizeof(u32));
589589
if (ret < 0 && ret != -ETIMEDOUT)
590590
dev_err(ucsi->dev, "UCSI_GET_PDOS failed (%d)\n", ret);
591-
if (ret == 0 && offset == 0)
592-
dev_warn(ucsi->dev, "UCSI_GET_PDOS returned 0 bytes\n");
593591

594592
return ret;
595593
}

0 commit comments

Comments
 (0)