Skip to content

Commit 51eaa86

Browse files
committed
Merge tag 'ras_core_for_v6.1_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull x86 RAS updates from Borislav Petkov: - Fix the APEI MCE callback handler to consult the hardware about the granularity of the memory error instead of hard-coding it - Offline memory pages on Intel machines after 2 errors reported per page * tag 'ras_core_for_v6.1_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/mce: Retrieve poison range from hardware RAS/CEC: Reduce offline page threshold for Intel systems
2 parents 7db99f0 + f9781bb commit 51eaa86

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

arch/x86/kernel/cpu/mce/apei.c

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,26 @@
2929
void apei_mce_report_mem_error(int severity, struct cper_sec_mem_err *mem_err)
3030
{
3131
struct mce m;
32+
int lsb;
3233

3334
if (!(mem_err->validation_bits & CPER_MEM_VALID_PA))
3435
return;
3536

37+
/*
38+
* Even if the ->validation_bits are set for address mask,
39+
* to be extra safe, check and reject an error radius '0',
40+
* and fall back to the default page size.
41+
*/
42+
if (mem_err->validation_bits & CPER_MEM_VALID_PA_MASK)
43+
lsb = find_first_bit((void *)&mem_err->physical_addr_mask, PAGE_SHIFT);
44+
else
45+
lsb = PAGE_SHIFT;
46+
3647
mce_setup(&m);
3748
m.bank = -1;
3849
/* Fake a memory read error with unknown channel */
3950
m.status = MCI_STATUS_VAL | MCI_STATUS_EN | MCI_STATUS_ADDRV | MCI_STATUS_MISCV | 0x9f;
40-
m.misc = (MCI_MISC_ADDR_PHYS << 6) | PAGE_SHIFT;
51+
m.misc = (MCI_MISC_ADDR_PHYS << 6) | lsb;
4152

4253
if (severity >= GHES_SEV_RECOVERABLE)
4354
m.status |= MCI_STATUS_UC;

drivers/ras/cec.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,14 @@ static int __init cec_init(void)
556556
if (ce_arr.disabled)
557557
return -ENODEV;
558558

559+
/*
560+
* Intel systems may avoid uncorrectable errors
561+
* if pages with corrected errors are aggressively
562+
* taken offline.
563+
*/
564+
if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
565+
action_threshold = 2;
566+
559567
ce_arr.array = (void *)get_zeroed_page(GFP_KERNEL);
560568
if (!ce_arr.array) {
561569
pr_err("Error allocating CE array page!\n");

0 commit comments

Comments
 (0)