Skip to content

Commit 9d92925

Browse files
committed
dt-bindings: pinctrl: samsung: deprecate header with register constants
For convenience (less code duplication, some meaning added to raw number), the pin controller pin configuration register values were defined in the bindings header. These are not some IDs or other abstraction layer but raw numbers used in the registers These constants do not fit the purpose of bindings. They do not provide any abstraction, any hardware and driver independent ID. With minor exceptions, the Linux drivers actually do not use the bindings header at all. All of the constants were moved already to headers local to DTS (residing in DTS directory) and to Samsung pinctrl driver (where applicable), so remove any references to the bindings header and add a warning tha tit is deprecated. Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Chanho Park <[email protected]> Acked-by: Rob Herring <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent df80530 commit 9d92925

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

include/dt-bindings/pinctrl/samsung.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@
1010
#ifndef __DT_BINDINGS_PINCTRL_SAMSUNG_H__
1111
#define __DT_BINDINGS_PINCTRL_SAMSUNG_H__
1212

13+
/*
14+
* These bindings are deprecated, because they do not match the actual
15+
* concept of bindings but rather contain pure register values.
16+
* Instead include the header in the DTS source directory.
17+
*/
18+
#warning "These bindings are deprecated. Instead use the header in the DTS source directory."
19+
1320
#define EXYNOS_PIN_PULL_NONE 0
1421
#define EXYNOS_PIN_PULL_DOWN 1
1522
#define EXYNOS_PIN_PULL_UP 3

0 commit comments

Comments
 (0)