Skip to content

Commit 9fd2cf4

Browse files
Dan Carpenterdjbw
authored andcommitted
cxl/region: Fix IS_ERR() vs NULL check
The nvdimm_pmem_region_create() function returns NULL on error. It does not return error pointers. Fixes: 04ad63f ("cxl/region: Introduce cxl_pmem_region objects") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Link: https://lore.kernel.org/r/Yuo65lq2WtfdGJ0X@kili Signed-off-by: Dan Williams <[email protected]>
1 parent e29a899 commit 9fd2cf4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/cxl/pmem.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,8 +525,8 @@ static int cxl_pmem_region_probe(struct device *dev)
525525

526526
cxlr_pmem->nd_region =
527527
nvdimm_pmem_region_create(cxl_nvb->nvdimm_bus, &ndr_desc);
528-
if (IS_ERR(cxlr_pmem->nd_region)) {
529-
rc = PTR_ERR(cxlr_pmem->nd_region);
528+
if (!cxlr_pmem->nd_region) {
529+
rc = -ENOMEM;
530530
goto err;
531531
}
532532

0 commit comments

Comments
 (0)