Skip to content

Commit a775e4e

Browse files
committed
Revert "drm/amdgpu/display: set vblank_disable_immediate for DC"
This reverts commit 92020e8. This causes stuttering and timeouts with DMCUB for some users so revert it until we understand why and safely enable it to save power. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1887 Acked-by: Harry Wentland <[email protected]> Signed-off-by: Alex Deucher <[email protected]> Cc: Nicholas Kazlauskas <[email protected]> Cc: [email protected]
1 parent 5cb0e3f commit a775e4e

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ int amdgpu_irq_init(struct amdgpu_device *adev)
320320
if (!amdgpu_device_has_dc_support(adev)) {
321321
if (!adev->enable_virtual_display)
322322
/* Disable vblank IRQs aggressively for power-saving */
323+
/* XXX: can this be enabled for DC? */
323324
adev_to_drm(adev)->vblank_disable_immediate = true;
324325

325326
r = drm_vblank_init(adev_to_drm(adev), adev->mode_info.num_crtc);

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4259,9 +4259,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
42594259
}
42604260
}
42614261

4262-
/* Disable vblank IRQs aggressively for power-saving. */
4263-
adev_to_drm(adev)->vblank_disable_immediate = true;
4264-
42654262
/* loops over all connectors on the board */
42664263
for (i = 0; i < link_cnt; i++) {
42674264
struct dc_link *link = NULL;

0 commit comments

Comments
 (0)