Skip to content

Commit b408fad

Browse files
ConchuODLorenzo Pieralisi
authored andcommitted
dt-bindings: PCI: fu740-pci: fix missing clock-names
The commit b92225b ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings") removed the clock-names property as a requirement and from the example as it triggered unevaluatedProperty warnings. dtbs_check was not able to pick up on this at the time, but now can: arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected) From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml The property was already in use by the FU740 DTS and the clock must be enabled. The Linux and FreeBSD drivers require the property to enable the clocks correctly Re-add the property and its "clocks" dependency, while making it required. Link: https://lore.kernel.org/r/[email protected] Fixes: b92225b ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings") Fixes: 43cea11 ("dt-bindings: PCI: Add SiFive FU740 PCIe host controller") Signed-off-by: Conor Dooley <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Reviewed-by: Rob Herring <[email protected]>
1 parent 7f08e80 commit b408fad

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,12 @@ properties:
5151
description: A phandle to the PCIe power up reset line.
5252
maxItems: 1
5353

54+
clocks:
55+
maxItems: 1
56+
57+
clock-names:
58+
const: pcie_aux
59+
5460
pwren-gpios:
5561
description: Should specify the GPIO for controlling the PCI bus device power on.
5662
maxItems: 1
@@ -66,6 +72,7 @@ required:
6672
- interrupt-map-mask
6773
- interrupt-map
6874
- clocks
75+
- clock-names
6976
- resets
7077
- pwren-gpios
7178
- reset-gpios
@@ -104,6 +111,7 @@ examples:
104111
<0x0 0x0 0x0 0x2 &plic0 58>,
105112
<0x0 0x0 0x0 0x3 &plic0 59>,
106113
<0x0 0x0 0x0 0x4 &plic0 60>;
114+
clock-names = "pcie_aux";
107115
clocks = <&prci FU740_PRCI_CLK_PCIE_AUX>;
108116
resets = <&prci 4>;
109117
pwren-gpios = <&gpio 5 0>;

0 commit comments

Comments
 (0)