Skip to content

Commit f78d5e1

Browse files
andy-shevbroonie
authored andcommitted
regmap: trace: Remove useless check for NULL for bulk ops
If the buffer pointer is NULL we already are in troubles since regmap bulk API expects caller to provide valid parameters, it dereferences that without any checks before we call for traces. Moreover, the current code will print garbage in the case of buffer is NULL and length is not 0. Signed-off-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent d57f203 commit f78d5e1

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/base/regmap/trace.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ DECLARE_EVENT_CLASS(regmap_bulk,
8282
__assign_str(name, regmap_name(map));
8383
__entry->reg = reg;
8484
__entry->val_len = val_len;
85-
if (val)
86-
memcpy(__get_dynamic_array(buf), val, val_len);
85+
memcpy(__get_dynamic_array(buf), val, val_len);
8786
),
8887

8988
TP_printk("%s reg=%x val=%s", __get_str(name),

0 commit comments

Comments
 (0)