Skip to content

Commit 79ac26b

Browse files
committed
Remove client-side rate limiter from Sentry
Remove client-side rate limiter from Sentry Problem A cold start of many Dapr deployments would take a long time, and even cause some crash loops. Impact A large Dapr deployment would take a non-linear more amount of time that a smaller one to completely roll out. Root cause The Sentry Kubernetes client was configured with a rate limiter which would be exhausted when services all new Dapr deployment at once, cause many client to wait significantly. Solution Remove the client-side rate limiting from the Sentry Kubernetes client. Signed-off-by: joshvanl <[email protected]>
1 parent 91391fe commit 79ac26b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

docs/release_notes/v1.15.4.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,4 +143,4 @@ Daprd would not close Scheduler gRPC connections to hosts which no longer exist.
143143

144144
### Solution
145145

146-
Daprd now closes connections to Scheduler hosts when they are no longer in the list of active hosts.
146+
Daprd now closes connections to Scheduler hosts when they are no longer in the list of active hosts.

pkg/sentry/server/validator/kubernetes/kubernetes.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
"context"
1818
"errors"
1919
"fmt"
20+
"math"
2021
"strings"
2122

2223
"github.com/lestrrat-go/jwx/v2/jwt"
@@ -88,6 +89,9 @@ func New(opts Options) (validator.Validator, error) {
8889
return nil, err
8990
}
9091

92+
opts.RestConfig.RateLimiter = nil
93+
opts.RestConfig.QPS = math.MaxFloat32
94+
opts.RestConfig.Burst = math.MaxInt
9195
cache, err := cache.New(opts.RestConfig, cache.Options{Scheme: scheme})
9296
if err != nil {
9397
return nil, err

0 commit comments

Comments
 (0)