Merge pull request dapr#8635 from JoshVanL/actors-reminders-always-set

Prevent panic of reminder operations on slow Actor Startup

Author: JoshVanL

docs/release_notes/v1.15.4.md

@@ -4,6 +4,7 @@ This update includes bug fixes:
 
 - [Fix degradation of Workflow runtime performance over time](#fix-degradation-of-workflow-runtime-performance-over-time)
 - [Allow Service Account for MetalBear mirrord operator in sidecar injector](#allow-service-account-for-metalbear-mirrord-operator-in-sidecar-injector)
+- [Prevent panic of reminder operations on slow Actor Startup](#prevent-panic-of-reminder-operations-on-slow-actor-startup)
 
 ## Fix degradation of Workflow runtime performance over time
 
@@ -41,4 +42,22 @@ Mirrord Operator is not on the allow list of Service Accounts for the dapr sidec
 
 ### Solution
 
-Add the Mirrord Operator into the allow list of Service Accounts for the dapr sidecar injector.
+Add the Mirrord Operator into the allow list of Service Accounts for the dapr sidecar injector.
+
+## Prevent panic of reminder operations on slow Actor Startup
+
+### Problem
+
+The Dapr runtime HTTP server would panic if a reminder operation timed out while an Actor was starting up.
+
+### Impact
+
+The HTTP server would panic, causing degraded performance.
+
+### Root cause
+
+The Dapr runtime would attempt to use the reminder service before it was initialized.
+
+### Solution
+
+Correctly return an errors that the actor runtime was not ready in time for the reminder operation.

pkg/actors/actors.go

@@ -193,12 +193,10 @@ func (a *actors) Init(opts InitOptions) error {
 
 	storeEnabled := a.buildStateStore(opts, apiLevel)
 
-	if a.reminderStore != nil {
-		a.reminders = reminders.New(reminders.Options{
-			Storage: a.reminderStore,
-			Table:   a.table,
-		})
-	}
+	a.reminders = reminders.New(reminders.Options{
+		Storage: a.reminderStore,
+		Table:   a.table,
+	})
 
 	var err error
 	a.placement, err = placement.New(placement.Options{
@@ -357,6 +355,10 @@ func (a *actors) Reminders(ctx context.Context) (reminders.Interface, error) {
 		return nil, err
 	}
 
+	if a.reminders == nil {
+		return nil, messages.ErrActorRuntimeNotFound
+	}
+
 	return a.reminders, nil
 }
 
@@ -374,7 +376,7 @@ func (a *actors) waitForReady(ctx context.Context) error {
 		}
 		return nil
 	case <-ctx.Done():
-		return ctx.Err()
+		return messages.ErrActorRuntimeNotFound
 	}
 }