Skip to content

Commit dc20cbc

Browse files
committed
fixes
1 parent 7da9eb2 commit dc20cbc

File tree

3 files changed

+25
-10
lines changed

3 files changed

+25
-10
lines changed

examples/factoradic.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def int_to_factoradic(num: int) -> str:
4141
return Stream(digits).map(DIGITS.__getitem__).collect("".join)
4242

4343

44-
def test() -> None:
44+
def test() -> int | str:
4545
"""Test this."""
4646
test_cases: tuple[tuple[int, str], ...] = (
4747
(1, "1"),
@@ -59,8 +59,12 @@ def test() -> None:
5959
)
6060

6161
for i, f in test_cases:
62-
assert (_ := factoradic_to_int(f)) == i, f"{_!r} != {i!r}"
63-
assert (_ := int_to_factoradic(i)) == f, f"{_!r} != {f!r}"
62+
if (_ := factoradic_to_int(f)) != i:
63+
return f"{_!r} != {i!r}"
64+
if (_ := int_to_factoradic(i)) != f:
65+
return f"{_!r} != {f!r}"
66+
67+
return 0
6468

6569

6670
if __name__ == "__main__":

examples/nth_prime.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
#!/bin/sh
2+
set -e
3+
24
if [ -z "$1" ]; then
35
N="1"
46
else
57
N="$1"
68
fi
79

10+
set -u
11+
812
if [ -f "./nth_prime.sh" ]; then
913
DIR="."
1014
elif [ -f "./examples/nth_prime.sh" ]; then

examples/test/__main__.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from __future__ import annotations
44

55
from pathlib import Path
6-
from subprocess import PIPE, run
6+
from subprocess import PIPE, run # nosec
77

88
from ..factoradic import test
99
from ..print_primes import test_prime_stream
@@ -16,9 +16,16 @@
1616

1717
def _get_nth_prime(num: int) -> int:
1818
"""Run nth_prime.sh."""
19-
command = [(EXAMPLES_DIR / "nth_prime.sh").as_posix(), str(num)]
20-
return int(run(command, check=True, stdout=PIPE).stdout)
21-
22-
23-
assert _get_nth_prime(100_000) == 1299709
24-
assert _get_nth_prime(200_000) == 2750159
19+
return int(
20+
run( # nosec
21+
["./nth_prime.sh", str(num)],
22+
check=True,
23+
stdout=PIPE,
24+
shell=False,
25+
cwd=EXAMPLES_DIR,
26+
).stdout
27+
)
28+
29+
30+
assert _get_nth_prime(100_000) == 1299709 # nosec
31+
assert _get_nth_prime(200_000) == 2750159 # nosec

0 commit comments

Comments
 (0)