chore: remove unnecessary should-semantic-release dependency and script (#1271)

## PR Checklist

- [x] Addresses an existing open issue: fixes #1270
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the unnecessary script... and thanks to Knip, the dependency
altogether.

Author: JoshuaKGoldberg

package.json

@@ -28,7 +28,6 @@
 		"lint:packages": "pnpm dedupe --check",
 		"lint:spelling": "cspell \"**\" \".github/**/*\"",
 		"prepare": "husky install",
-		"should-semantic-release": "should-semantic-release --verbose",
 		"test": "vitest",
 		"test:create": "node script/create-test-e2e.js",
 		"test:initialize": "node script/initialize-test-e2e.js",
@@ -96,7 +95,6 @@
 		"prettier-plugin-packagejson": "^2.4.7",
 		"release-it": "^17.0.0",
 		"sentences-per-line": "^0.2.1",
-		"should-semantic-release": "^0.2.1",
 		"tsup": "^8.0.1",
 		"tsx": "^4.6.2",
 		"typescript": "^5.3.3",

pnpm-lock.yaml

@@ -1,7 +1,7 @@
 import { readPackageData } from "../packages.js";
 import { OptionsBase } from "../types.js";
 
-const commonScripts = new Set(["lint:knip", "should-semantic-release", "test"]);
+const commonScripts = new Set(["lint:knip", "test"]);
 
 const everythingScripts = new Set([
 	"lint:md",

src/shared/options/getBase.ts

@@ -38,7 +38,7 @@ describe("finalize", () => {
 		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
 			[
 			  [
-			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-no-only-tests@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest should-semantic-release@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D",
+			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-no-only-tests@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D",
 			  ],
 			  [
 			    "npx all-contributors-cli generate",
@@ -59,7 +59,7 @@ describe("finalize", () => {
 		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
 			[
 			  [
-			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-no-only-tests@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest should-semantic-release@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D --offline",
+			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-no-only-tests@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D --offline",
 			  ],
 			  [
 			    "npx all-contributors-cli generate",

src/steps/finalizeDependencies.test.ts

@@ -45,11 +45,7 @@ export async function finalizeDependencies(options: Options) {
 			: ["eslint-plugin-yml", "yaml-eslint-parser"]),
 		...(options.excludeReleases
 			? []
-			: [
-					"@release-it/conventional-changelog",
-					"release-it",
-					"should-semantic-release",
-			  ]),
+			: ["@release-it/conventional-changelog", "release-it"]),
 		...(options.excludeTests
 			? []
 			: [

src/steps/finalizeDependencies.ts

@@ -108,7 +108,6 @@ describe("writePackageJson", () => {
 			    "lint:packages": "pnpm dedupe --check",
 			    "lint:spelling": "cspell "**" ".github/**/*"",
 			    "prepare": "husky install",
-			    "should-semantic-release": "should-semantic-release --verbose",
 			    "test": "vitest",
 			    "tsc": "tsc",
 			  },

src/steps/writing/creation/writePackageJson.test.ts

@@ -102,9 +102,6 @@ export async function writePackageJson(options: Options) {
 				"lint:spelling": 'cspell "**" ".github/**/*"',
 			}),
 			prepare: "husky install",
-			...(!options.excludeReleases && {
-				"should-semantic-release": "should-semantic-release --verbose",
-			}),
 			...(!options.excludeReleases && { test: "vitest" }),
 			tsc: "tsc",
 		},