fix(setup-test): remove shell true (#367)

<!-- 👋 Hi, thanks for sending a PR to template-typescript-node-package!
💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #357
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
Added [`globby`](https://github.com/sindresorhus/globby) package. Reason
-
sindresorhus/execa#555 (comment)

---------

Co-authored-by: Josh Goldberg ✨ <[email protected]>

Author: navin-moorthy

knip.jsonc

@@ -1,6 +1,6 @@
 {
 	"$schema": "https://unpkg.com/knip@next/schema.json",
 	"entry": ["src/index.ts!", "script/setup*.js"],
-	"ignoreBinaries": ["gh"],
+	"ignoreBinaries": ["gh", "grep"],
 	"project": ["src/**/*.ts!", "script/**/*.js"]
 }

package.json

@@ -58,6 +58,7 @@
 		"eslint-plugin-vitest": "^0.0.57",
 		"eslint-plugin-yml": "^1.5.0",
 		"execa": "^7.1.1",
+		"globby": "^13.1.3",
 		"husky": "^8.0.3",
 		"jsonc-eslint-parser": "^2.1.0",
 		"knip": "2.8.2",

pnpm-lock.yaml

@@ -2,6 +2,7 @@ import { strict as assert } from "node:assert";
 
 import { $ } from "execa";
 import { promises as fs } from "fs";
+import { globby } from "globby";
 
 const description = "New Description Test";
 const owner = "NewOwnerTest";
@@ -20,15 +21,16 @@ console.log("New package JSON:", newPackageJson);
 assert.equal(newPackageJson.description, description);
 assert.equal(newPackageJson.name, repository);
 
+const files = await globby(["*.*", "**/*.*"], {
+	gitignore: true,
+	ignoreFiles: ["script/setup.js", "script/setup-test-e2e.js"],
+});
+
 for (const search of [
 	`/JoshuaKGoldberg/`,
 	"template-typescript-node-package",
 ]) {
-	const { stdout } = await $({
-		// Todo: it'd be nice to not have to use this... but we haven't figured out how yet.
-		// https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues/357
-		shell: true,
-	})`grep --exclude script/setup.js --exclude script/setup-test-e2e.js --exclude-dir node_modules -i ${search} *.* **/*.*`;
+	const { stdout } = await $`grep -i ${search} ${files}`;
 	assert.equal(
 		stdout,
 		`README.md:> 💙 This package is based on [@JoshuaKGoldberg](https://github.com/JoshuaKGoldberg)'s [template-typescript-node-package](https://github.com/JoshuaKGoldberg/template-typescript-node-package).`

script/setup-test-e2e.js

@@ -519,7 +519,7 @@ try {
 
 		await withSpinner(
 			async () => {
-				await $`pnpm remove execa @clack/prompts all-contributors-cli chalk octokit npm-user replace-in-file title-case -D`;
+				await $`pnpm remove execa globby @clack/prompts all-contributors-cli chalk octokit npm-user replace-in-file title-case -D`;
 			},
 			{
 				startText: `Removing devDependency packages only used for setup...`,