Skip to content

Commit 2872a16

Browse files
fix: also run npx all-contributors-cli generate in setup (#664)
## PR Checklist - [x] Addresses an existing open issue: fixes #663 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview I think it's fine to run the command both in hydration and setup. It's not slow.
1 parent 8e287a5 commit 2872a16

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/hydrate/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import { runOrRestore } from "../shared/runOrRestore.js";
1010
import { clearUnnecessaryFiles } from "./steps/clearUnnecessaryFiles.js";
1111
import { detectExistingContributors } from "./steps/detectExistingContributors.js";
12-
import { finalizeDependencies as finalizeDependencies } from "./steps/finalizeDependencies.js";
12+
import { finalizeDependencies } from "./steps/finalizeDependencies.js";
1313
import { runCommand } from "./steps/runCommand.js";
1414
import { writeReadme } from "./steps/writeReadme.js";
1515
import { writeStructure } from "./steps/writing/writeStructure.js";

src/hydrate/steps/finalizeDependencies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export async function finalizeDependencies({
5757

5858
for (const command of [
5959
`pnpm add ${devDependencies.map(atLatest).join(" ")} -D`,
60-
`npx all-contributors generate`,
60+
`npx all-contributors-cli generate`,
6161
`pnpm uninstall all-contributors-cli all-contributors-for-repository -D`,
6262
"pnpm run format:write",
6363
]) {

src/setup/steps/updateAllContributorsTable.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { $ } from "execa";
12
import fs from "node:fs/promises";
23
import prettier from "prettier";
34

@@ -22,4 +23,6 @@ export async function updateAllContributorsTable({
2223
{ parser: "json" },
2324
),
2425
);
26+
27+
await $`npx all-contributors-cli generate`;
2528
}

0 commit comments

Comments
 (0)