Skip to content

Commit 4acc270

Browse files
fix: place newlines between README.md badges (#754)
## PR Checklist - [x] Addresses an existing open issue: fixes #753 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Joins with `"\n"` instead of `""`.
1 parent d34ba2d commit 4acc270

File tree

2 files changed

+28
-13
lines changed

2 files changed

+28
-13
lines changed

src/steps/writeReadme.test.ts

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,18 @@ describe("writeReadme", () => {
7474
<img alt=\\"All Contributors: 2\\" src=\\"https://img.shields.io/badge/all_contributors-17-21bb42.svg\\" />
7575
<!-- ALL-CONTRIBUTORS-BADGE:END -->
7676
<!-- prettier-ignore-end -->
77-
</a><a href=\\"https://codecov.io/gh/TestOwner/test-repository\\" target=\\"_blank\\">
77+
</a>
78+
<a href=\\"https://codecov.io/gh/TestOwner/test-repository\\" target=\\"_blank\\">
7879
<img alt=\\"Codecov Test Coverage\\" src=\\"https://codecov.io/gh/TestOwner/test-repository/branch/main/graph/badge.svg\\"/>
79-
</a><a href=\\"https://github.com/TestOwner/test-repository/blob/main/.github/CODE_OF_CONDUCT.md\\" target=\\"_blank\\">
80+
</a>
81+
<a href=\\"https://github.com/TestOwner/test-repository/blob/main/.github/CODE_OF_CONDUCT.md\\" target=\\"_blank\\">
8082
<img alt=\\"Contributor Covenant\\" src=\\"https://img.shields.io/badge/code_of_conduct-enforced-21bb42\\" />
81-
</a><a href=\\"https://github.com/TestOwner/test-repository/blob/main/LICENSE.md\\" target=\\"_blank\\">
83+
</a>
84+
<a href=\\"https://github.com/TestOwner/test-repository/blob/main/LICENSE.md\\" target=\\"_blank\\">
8285
<img alt=\\"License: MIT\\" src=\\"https://img.shields.io/github/license/TestOwner/test-repository?color=21bb42\\">
83-
</a><img alt=\\"Style: Prettier\\" src=\\"https://img.shields.io/badge/style-prettier-21bb42.svg\\" /><img alt=\\"TypeScript: Strict\\" src=\\"https://img.shields.io/badge/typescript-strict-21bb42.svg\\" />
86+
</a>
87+
<img alt=\\"Style: Prettier\\" src=\\"https://img.shields.io/badge/style-prettier-21bb42.svg\\" />
88+
<img alt=\\"TypeScript: Strict\\" src=\\"https://img.shields.io/badge/typescript-strict-21bb42.svg\\" />
8489
</p>
8590
8691
## Contributors
@@ -126,13 +131,18 @@ describe("writeReadme", () => {
126131
<img alt=\\"All Contributors: 2\\" src=\\"https://img.shields.io/badge/all_contributors-17-21bb42.svg\\" />
127132
<!-- ALL-CONTRIBUTORS-BADGE:END -->
128133
<!-- prettier-ignore-end -->
129-
</a><a href=\\"https://codecov.io/gh/TestOwner/test-repository\\" target=\\"_blank\\">
134+
</a>
135+
<a href=\\"https://codecov.io/gh/TestOwner/test-repository\\" target=\\"_blank\\">
130136
<img alt=\\"Codecov Test Coverage\\" src=\\"https://codecov.io/gh/TestOwner/test-repository/branch/main/graph/badge.svg\\"/>
131-
</a><a href=\\"https://github.com/TestOwner/test-repository/blob/main/.github/CODE_OF_CONDUCT.md\\" target=\\"_blank\\">
137+
</a>
138+
<a href=\\"https://github.com/TestOwner/test-repository/blob/main/.github/CODE_OF_CONDUCT.md\\" target=\\"_blank\\">
132139
<img alt=\\"Contributor Covenant\\" src=\\"https://img.shields.io/badge/code_of_conduct-enforced-21bb42\\" />
133-
</a><a href=\\"https://github.com/TestOwner/test-repository/blob/main/LICENSE.md\\" target=\\"_blank\\">
140+
</a>
141+
<a href=\\"https://github.com/TestOwner/test-repository/blob/main/LICENSE.md\\" target=\\"_blank\\">
134142
<img alt=\\"License: MIT\\" src=\\"https://img.shields.io/github/license/TestOwner/test-repository?color=21bb42\\">
135-
</a><img alt=\\"Style: Prettier\\" src=\\"https://img.shields.io/badge/style-prettier-21bb42.svg\\" /><img alt=\\"TypeScript: Strict\\" src=\\"https://img.shields.io/badge/typescript-strict-21bb42.svg\\" />
143+
</a>
144+
<img alt=\\"Style: Prettier\\" src=\\"https://img.shields.io/badge/style-prettier-21bb42.svg\\" />
145+
<img alt=\\"TypeScript: Strict\\" src=\\"https://img.shields.io/badge/typescript-strict-21bb42.svg\\" />
136146
</p>
137147
138148
## Contributors
@@ -224,13 +234,18 @@ describe("writeReadme", () => {
224234
<img alt=\\"All Contributors: 2\\" src=\\"https://img.shields.io/badge/all_contributors-17-21bb42.svg\\" />
225235
<!-- ALL-CONTRIBUTORS-BADGE:END -->
226236
<!-- prettier-ignore-end -->
227-
</a><a href=\\"https://codecov.io/gh/TestOwner/test-repository\\" target=\\"_blank\\">
237+
</a>
238+
<a href=\\"https://codecov.io/gh/TestOwner/test-repository\\" target=\\"_blank\\">
228239
<img alt=\\"Codecov Test Coverage\\" src=\\"https://codecov.io/gh/TestOwner/test-repository/branch/main/graph/badge.svg\\"/>
229-
</a><a href=\\"https://github.com/TestOwner/test-repository/blob/main/.github/CODE_OF_CONDUCT.md\\" target=\\"_blank\\">
240+
</a>
241+
<a href=\\"https://github.com/TestOwner/test-repository/blob/main/.github/CODE_OF_CONDUCT.md\\" target=\\"_blank\\">
230242
<img alt=\\"Contributor Covenant\\" src=\\"https://img.shields.io/badge/code_of_conduct-enforced-21bb42\\" />
231-
</a><a href=\\"https://github.com/TestOwner/test-repository/blob/main/LICENSE.md\\" target=\\"_blank\\">
243+
</a>
244+
<a href=\\"https://github.com/TestOwner/test-repository/blob/main/LICENSE.md\\" target=\\"_blank\\">
232245
<img alt=\\"License: MIT\\" src=\\"https://img.shields.io/github/license/TestOwner/test-repository?color=21bb42\\">
233-
</a><img alt=\\"Style: Prettier\\" src=\\"https://img.shields.io/badge/style-prettier-21bb42.svg\\" /><img alt=\\"TypeScript: Strict\\" src=\\"https://img.shields.io/badge/typescript-strict-21bb42.svg\\" />
246+
</a>
247+
<img alt=\\"Style: Prettier\\" src=\\"https://img.shields.io/badge/style-prettier-21bb42.svg\\" />
248+
<img alt=\\"TypeScript: Strict\\" src=\\"https://img.shields.io/badge/typescript-strict-21bb42.svg\\" />
234249
</p>
235250
236251
<p align=\\"center\\">Test description.</p>

src/steps/writeReadme.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,6 @@ function generateTopContent(options: Options) {
105105
<p align="center">${options.description}</p>
106106
107107
<p align="center">
108-
${badgeLines.join("")}
108+
${badgeLines.join("\n")}
109109
</p>`;
110110
}

0 commit comments

Comments
 (0)