fix: respect existing contributors in hydration (#638)

## PR Checklist

- [x] Addresses an existing open issue: fixes #449
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Reads the existing `.all-contributorsrc` if it exists.

Shuffles code around a bit to make a new shared `readFileAsJsonSafe`.

Author: JoshuaKGoldberg

src/hydrate/steps/writeReadme.ts

@@ -1,6 +1,6 @@
 import * as fs from "node:fs/promises";
 
-import { readFileSafe } from "../readFileSafe.js";
+import { readFileSafe } from "../../shared/readFileSafe.js";
 import { HydrationInputValues } from "../values/types.js";
 
 const contributorsIndicator = `<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->`;

src/hydrate/steps/writing/creation/rootFiles.ts

@@ -1,25 +1,12 @@
 import { HydrationInputValues } from "../../../values/types.js";
 import { formatIgnoreFile } from "./formatters/formatIgnoreFile.js";
 import { formatJson } from "./formatters/formatJson.js";
+import { writeAllContributorsRC } from "./writeAllContributorsRC.js";
 import { writePackageJson } from "./writePackageJson.js";
 
 export async function createRootFiles(values: HydrationInputValues) {
 	return {
-		".all-contributorsrc": await formatJson({
-			badgeTemplate:
-				'<img alt="All Contributors: <%= contributors.length %>" src="https://img.shields.io/badge/all_contributors-<%= contributors.length %>-21bb42.svg" />',
-			commit: false,
-			commitConvention: "angular",
-			contributors: [],
-			contributorsPerLine: 7,
-			contributorsSortAlphabetically: true,
-			files: ["README.md"],
-			imageSize: 100,
-			projectName: values.repository,
-			projectOwner: values.owner,
-			repoHost: "https://github.com",
-			repoType: "github",
-		}),
+		".all-contributorsrc": await writeAllContributorsRC(values),
 		".eslintignore": formatIgnoreFile([
 			"!.*",
 			...(values.unitTests ? ["coverage"] : []),

src/hydrate/steps/writing/creation/writeAllContributorsRC.ts

@@ -0,0 +1,26 @@
+import { readFileSafeAsJson } from "../../../../shared/readFileSafeAsJson.js";
+import { AllContributorsData } from "../../../../shared/types.js";
+import { HydrationInputValues } from "../../../values/types.js";
+import { formatJson } from "./formatters/formatJson.js";
+
+export async function writeAllContributorsRC(values: HydrationInputValues) {
+	const existing = (await readFileSafeAsJson(
+		".all-contributorsrc",
+	)) as AllContributorsData | null;
+
+	return await formatJson({
+		badgeTemplate:
+			'<img alt="All Contributors: <%= contributors.length %>" src="https://img.shields.io/badge/all_contributors-<%= contributors.length %>-21bb42.svg" />',
+		commit: false,
+		commitConvention: "angular",
+		contributors: existing?.contributors ?? [],
+		contributorsPerLine: 7,
+		contributorsSortAlphabetically: true,
+		files: ["README.md"],
+		imageSize: 100,
+		projectName: values.repository,
+		projectOwner: values.owner,
+		repoHost: "https://github.com",
+		repoType: "github",
+	});
+}

src/hydrate/values/getHydrationDefaults.test.ts

@@ -4,7 +4,7 @@ import { getHydrationDefaults } from "./getHydrationDefaults.js";
 
 const mockReadFileSafe = vi.fn();
 
-vi.mock("../readFileSafe.js", () => ({
+vi.mock("../../shared/readFileSafe.js", () => ({
 	get readFileSafe() {
 		return mockReadFileSafe;
 	},

src/hydrate/values/getHydrationDefaults.ts

@@ -1,6 +1,6 @@
 import type { PartialPackageData } from "./types.js";
 
-import { readFileSafe } from "../readFileSafe.js";
+import { readFileSafe } from "../../shared/readFileSafe.js";
 import { readAuthorIfExists } from "./readAuthorIfExists.js";
 import { readEmailIfExists } from "./readEmailIfExists.js";
 import { readFundingIfExists } from "./readFundingIfExists.js";

src/hydrate/values/readTitleFromReadme.test.ts

@@ -4,7 +4,7 @@ import { readTitleFromReadme } from "./readTitleFromReadme.js";
 
 const mockReadFileSafe = vi.fn();
 
-vi.mock("../readFileSafe.js", () => ({
+vi.mock("../../shared/readFileSafe.js", () => ({
 	get readFileSafe() {
 		return mockReadFileSafe;
 	},

src/hydrate/values/readTitleFromReadme.ts

@@ -1,4 +1,4 @@
-import { readFileSafe } from "../readFileSafe.js";
+import { readFileSafe } from "../../shared/readFileSafe.js";
 
 export async function readTitleFromReadme() {
 	return (

src/setup/settings/addOwnerAsAllContributor.ts

@@ -4,6 +4,7 @@ import fs from "node:fs/promises";
 import prettier from "prettier";
 
 import { readFileAsJson } from "../../shared/readFileAsJson.js";
+import { AllContributorsData } from "../../shared/types.js";
 
 interface GhUserOutput {
 	login: string;
@@ -60,10 +61,6 @@ export async function addOwnerAsAllContributor(owner: string) {
 	);
 }
 
-interface AllContributorsData {
-	contributors: { contributions: string[]; login: string }[];
-}
-
 function isValidAllContributorsData(
 	value: unknown,
 ): value is AllContributorsData {

src/setup/setupWithInformation.ts

@@ -13,7 +13,6 @@ import { hydrateRepositoryLabels } from "./steps/labels/hydrateRepositoryLabels.
 import { removeSetupScripts } from "./steps/removeSetupScripts.js";
 import { resetGitTags } from "./steps/resetGitTags.js";
 import { uninstallPackages } from "./steps/uninstallPackages.js";
-import { updateAllContributorsFile } from "./steps/updateAllContributorsFile.js";
 import { updateAllContributorsTable } from "./steps/updateAllContributorsTable.js";
 import { updateLocalFiles } from "./steps/updateLocalFiles.js";
 import { updateReadme } from "./steps/updateReadme.js";
@@ -34,10 +33,6 @@ export async function setupWithInformation({
 		await updateLocalFiles({ ...values, npmAuthor });
 	}, "Updating all the files with provided details.");
 
-	await withSpinner(async () => {
-		await updateAllContributorsFile(values);
-	}, "Updating '.all-contributorsrc' with new repository details.");
-
 	await withSpinner(
 		updateReadme,
 		"Appending template-typescript-node-package notice to 'README.md'",