Skip to content

Commit eb1da72

Browse files
docs: mention status checks (#360)
## PR Checklist - [x] Addresses an existing open issue: fixes #359 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Further splits up the PR docs.
1 parent 77a2688 commit eb1da72

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ When a PR is not in draft, it's considered ready for review.
5353
Please don't manually `@` tag anybody to request review.
5454
A maintainer will look at it when they're next able to.
5555

56+
PRs should have passing [GitHub status checks](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks) before review is requested (unless there are explicit questions asked in the PR about any failures).
57+
58+
#### Requested Changes
59+
5660
After a maintainer reviews your PR, they may request changes on it.
5761
Once you've made those changes, [re-request review on GitHub](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review).
5862

0 commit comments

Comments
 (0)