Skip to content

Commit f0c1dbd

Browse files
feat: bumped typescript-eslint to v6.0.0 (#601)
## PR Checklist - [x] Addresses an existing open issue: fixes #600 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Bumps the version. I didn't see any need to tweak manual rules, just the preset configs. And hey, [`plugin:@typescript-eslint/no-confusing-void-expression`](https://typescript-eslint.io/rules/no-confusing-void-expression) found an unnecessary `return` - nice!
1 parent 1f30a32 commit f0c1dbd

File tree

5 files changed

+99
-66
lines changed

5 files changed

+99
-66
lines changed

.eslintrc.cjs

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ module.exports = {
3131
{
3232
extends: [
3333
"plugin:jsdoc/recommended-typescript-error",
34-
"plugin:@typescript-eslint/recommended",
34+
"plugin:@typescript-eslint/strict",
35+
"plugin:@typescript-eslint/stylistic",
3536
],
3637
files: ["**/*.ts"],
3738
parser: "@typescript-eslint/parser",
@@ -49,8 +50,8 @@ module.exports = {
4950
{
5051
excludedFiles: ["**/*.md/*.ts"],
5152
extends: [
52-
"plugin:@typescript-eslint/recommended-requiring-type-checking",
53-
"plugin:@typescript-eslint/strict",
53+
"plugin:@typescript-eslint/strict-type-checked",
54+
"plugin:@typescript-eslint/stylistic-type-checked",
5455
],
5556
files: ["**/*.ts"],
5657
parser: "@typescript-eslint/parser",
@@ -79,6 +80,12 @@ module.exports = {
7980
"jsonc/sort-keys": "error",
8081
},
8182
},
83+
{
84+
files: ["*.jsonc"],
85+
rules: {
86+
"jsonc/no-comments": "off",
87+
},
88+
},
8289
{
8390
files: "**/*.test.ts",
8491
rules: {

knip.jsonc

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,16 @@
77
"script/*e2e.js"
88
],
99
"ignoreBinaries": ["dedupe", "gh"],
10-
"ignoreDependencies": ["all-contributors-cli", "c8"],
10+
"ignoreDependencies": [
11+
// TODO: investigate if these are still flagged, and file issues if not
12+
"all-contributors-cli",
13+
"c8",
14+
15+
// https://github.com/webpro/knip/issues/154
16+
"@typescript-eslint/eslint-plugin-strict-type-checked",
17+
"@typescript-eslint/eslint-plugin-stylistic",
18+
"@typescript-eslint/eslint-plugin-stylistic-type-checked"
19+
],
1120
"ignoreExportsUsedInFile": {
1221
"interface": true,
1322
"type": true

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@
6060
"@types/git-url-parse": "^9.0.1",
6161
"@types/js-yaml": "^4.0.5",
6262
"@types/prettier": "^2.7.2",
63-
"@typescript-eslint/eslint-plugin": "^5.59.5",
64-
"@typescript-eslint/parser": "^5.59.5",
63+
"@typescript-eslint/eslint-plugin": "^6.0.0",
64+
"@typescript-eslint/parser": "^6.0.0",
6565
"@vitest/coverage-istanbul": "^0.33.0",
6666
"all-contributors-cli": "^6.25.1",
6767
"c8": "^8.0.0",

pnpm-lock.yaml

Lines changed: 76 additions & 59 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/hydrate/steps/writing/writeStructure.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ import { createStructure } from "./creation/index.js";
33
import { writeStructureWorker } from "./writeStructureWorker.js";
44

55
export async function writeStructure(values: HydrationInputValues) {
6-
return await writeStructureWorker(await createStructure(values), ".");
6+
await writeStructureWorker(await createStructure(values), ".");
77
}

0 commit comments

Comments
 (0)